search

youknowone / ring

Python cache interface with clean API and built-in memcache & redis + asyncio support.
http://ring-cache.readthedocs.io/en/latest/
Other
480 stars 37 forks source link

expiringdict for ring.dict(expire) #123

Open youknowone opened 5 years ago

youknowone commented 5 years ago

https://pypi.org/project/expiringdict/

Instead of ExpirableDictStorage implementation, replacing dict to expringdict looks simpler and reasonable

seeeturtle commented 5 years ago

@youknowone, i tried to use ExpiringDict but it seems PyPI is not following up the master branch. the last release of PyPI is Sep, 2017.

i guess it's not a good idea to useexpiringdict.

youknowone commented 5 years ago

Hello, thanks for trying to contribute about this issue.

By checking expiringdict commits in https://github.com/mailgun/expiringdict/commits/master, it seems there was not much changes since 2017. The changes also not looks like critical issues about the project. If there is not known issues about the project, I think this can be proof of stability and concreteness of the project. How do you think about it?

seeeturtle commented 5 years ago

I think the problem is that there is no option for permanent cache. If we want to implement that feature, I think it’s not really different from current implementation of ring.

나의 iPad에서 보냄

      1. 오전 12:44, Jeong YunWon notifications@github.com 작성:

Hello, thanks for trying to contribute about this issue.

By checking expiringdict commits in https://github.com/mailgun/expiringdict/commits/master, it seems there was not much changes since 2017. The changes also not looks like critical issues about the project. If there is not known issues about the project, I think this can be proof of stability and concreteness of the project. How do you think about it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

youknowone commented 5 years ago

I think normal dict is good enough for permanent cache. For now, we use different backend for permanent cache and expirable cache. we can keep the permanent one as bow and just replace expirable one to expiringdict. Please let me know if there is any concern I missed.

seeeturtle commented 5 years ago

Ok, I got it. Thanks for answering my questions.