search

youknowriad / dropit

Insert photos from unsplash.com directly inside your Gutenberg Editor.
https://wordpress.org/plugins/dropit
GNU General Public License v2.0
47 stars 6 forks source link

Feature/giphy #5

Closed jmau111 closed 6 years ago

jmau111 commented 6 years ago

@youknowriad need your review. It's a very basic merge... maybe we should have something reusable. I did not want to change too much things in your original code, only paths for now.

jmau111 commented 6 years ago

@youknowriad ok I've done 2 little changes according to your review, it needs refactor but I think it's ok. There are some TODO : more gifs (currently only 5, more filters (currently by rate & sort by relevant), etc

Love the experience with the button + on sidebar

youknowriad commented 6 years ago

I just tested and it works great. Awesome work. I have a small concern. I think we shouldn't use a different icon for the Gifs. I think we should just use the same one as Unsplash (the dropit icon) with a different color and when you open the panel, we show: "Powered by Giphy in the title". What do you think?

I can update if you're fine with that.

jmau111 commented 6 years ago

Sounds cool same UI, but I'm afraid this won't be recognized maybe the icon should have title besides => unslash, giphy. I don't know if it's possible

jmau111 commented 6 years ago

@youknowriad let's try this.

The Giphy team has approved the app so we have now a production key \o/ They want us to use to GIPH embed object in the article so maybe I have to change the final markup a little bit.

jmau111 commented 6 years ago

actually GIPHY API team said markup is free but it would be better to use iFrame, I think we are fine with img for now so if you want to change icon then after it's probably safe to merge and release later.

Thanks for making this example, this allows us to know there are components we can use and other things ^^.

youknowriad commented 6 years ago

Cool thanks and sorry I've been a bit occupied these days, I'll try to catch up with this tomorrow hopefully (or this weekend).

youknowriad commented 6 years ago

Hey, so I made some tweaks to the code, mainly to unify the UI between unsplash and Giphy (using the same components). I think it's in a good shape.

jmau111 commented 6 years ago

looks better :+1: