search

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.43k stars 29 forks source link

Streams don't load on Firefox Nightly #107

Closed progamer63 closed 1 year ago

progamer63 commented 1 year ago

Debugging addon gives a "Reading manifest: Warning processing update_url: An unexpected property was found in the WebExtension manifest." warning. Stream video feeds are entirely blacked out.

younesaassila commented 1 year ago
  1. update_url key warning is expected. Doesn't cause any issues.
  2. What Firefox version? Works perfectly on Release and Dev editions for me.
progamer63 commented 1 year ago

It seems to be working now. I'm on Nightly, Version 113.0a1 (2023-03-26). Maybe it was just a temporary thing?

s-crypt commented 1 year ago

I am experiencing the same issue on Firefox Nightly 113.0a1 (2023-03-27) and it has been like this for a couple of days. The stream wont load, it is just stuck in a loading/buffering screen. Disabling the extension and refreshing the page has the stream work.

I cannot find anything in the browser console that is preventing the stream from loading.

The only logs in the console from the extension are

[TTV LOL PRO] Content script running.
[TTV LOL PRO] Page script running.
younesaassila commented 1 year ago

Can indeed reproduce on Nightly. The temporary fix is to disable the "Reset player on midroll" feature. I think this is due to some Nightly bug but I'll keep an eye on it in case this behavior ends up in the Release version of Firefox.

rohitsaha29 commented 1 year ago

The issue is still present for me on Firefox Nightly Version 113.0a1, just stays stuck on a black infinite loading screen when the stream first loads. Temporary fix of disabling reset player on midroll still works however.

younesaassila commented 1 year ago

Version 1.9.0 no longer requires you to disable the "Reset player on midroll" feature since it now properly falls back to the normal Twitch stream in case of error. The issue is still open though since the problem is still not fixed and the feature doesn't work.

Edit: The error is now also logged in the console with prefix "[TTV LOL PRO]"

younesaassila commented 1 year ago

Seems to be a Nightly-only bug! This doesn't happen in the 113 Beta: image but still does in 114 Nightly

younesaassila commented 1 year ago

Closing this issue since it was due to the "Reset player on midroll" feature which is now deprecated.