search

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.43k stars 29 forks source link

Muting Twitch causes Video to pause #133

Closed Ranmaz closed 1 year ago

Ranmaz commented 1 year ago

When I switch back to a twitch tab, it takes a moment for the Video to Load. To bypass this, I need to not mute the stream, and use the mute tab feature on my Edge web browser instead.

younesaassila commented 1 year ago

Does this behavior persist when you disable the extension? I'm pretty convinced this is an optimization done by Twitch. They are known to also drop the quality when a tab is in the background.

Ranmaz commented 1 year ago

It does not persist when I disable the extension.

Long story actually. I switch webbrowsers thinking it would resolve my issue (google to Edge). I noticed the issue happening again when I installed the extension.

younesaassila commented 1 year ago

Unfortunately, I am not able to reproduce this bug. Do you have "Reset player on midroll" turned off in TTV LOL PRO options? If not, please do so and report back.

Ranmaz commented 1 year ago

where is that option?

image

younesaassila commented 1 year ago

Ah sorry, I assumed you were using TTV LOL PRO v1. Still cannot reproduce. What country are you watching Twitch from?

Ranmaz commented 1 year ago

Canada

younesaassila commented 1 year ago

Could you try the America proxy listed in #130 and let me know if the issue persists

Ranmaz commented 1 year ago

america.ttvlolpro.perfprod.com:8014 Do I move this to the number 1 spot?

younesaassila commented 1 year ago

Yes put it as Primary/No. 1

Ranmaz commented 1 year ago

Same behavior. Although it loads faster. It's still very clear though, that when I have the stream sound on, and mute the tab, and switch back and forth between tabs, I return to where the stream was playing, and no stutter or re-loading.

Can I attach a video here? if not, i can link it to a youtube link.

younesaassila commented 1 year ago

Sure, a video could be helpful. GitHub lets you attach files, though I'm not sure what the size limit is and if a video would fit.

Ranmaz commented 1 year ago

It was too big, so I had to upload it to youtube instead https://youtu.be/qcBItWCnNqQ

It's probably still processing, give it a moment.

So youtube is not being friendly right now, it shouldn't take that long. I'm still working on getting this to you.

Ranmaz commented 1 year ago

ok youtube is not processing it. I uploaded it to dailymotion:

https://dai.ly/k57NCJbCSCKX3iz7TXz

Undead-Tech commented 1 year ago

This doesn't happen on brave but I am able to reproduce this on chrome. I can't test edge since I use a custom windows install that doesn't include it. If I find a way to fix it completely I'll post; however, I will add deleting site data and resetting site permissions for twitch fixes it until you close the tab or reload the site. Switching to other streams or going anywhere else on the site is fine until you reload or close the tab and go to twitch again.

Undead-Tech commented 1 year ago

So I have figured out that if the tab loads with the player already muted from a previous session it will do this. Unmuting the player and muting it again fixes it.

When inspecting the tab while this happens something from "player-core-variant-b-2c0fc18568332fa5dad8.js" is used. While I want to I don't know how to code currently so idk what else I could do to help. Hope this helps out. test

Ranmaz commented 1 year ago

So I have figured out that if the tab loads with the player already muted from a previous session it will do this. Unmuting the player and muting it again fixes it.

When inspecting the tab while this happens something from "player-core-variant-b-2c0fc18568332fa5dad8.js" is used. While I want to I don't know how to code currently so idk what else I could do to help. Hope this helps out. test

This is great! I can easily do that, but it would be nice if this can be fixed with the code. I can technically remind myself to do this, but it would be nice that this can be resolved without me having to unmuting and muting it again.

younesaassila commented 1 year ago

Still can't reproduce on Chrome. Though from what I can see from your video, the stream still plays fine after the few 100s milliseconds of loading. I still believe this is just Twitch doing some bandwidth savings and having to quick reload the stream on tab re-focus. I'll let the issue open a bit to see if other people can reproduce and debug what's happening network-wise

Ranmaz commented 1 year ago

Still can't reproduce on Chrome. Though from what I can see from your video, the stream still plays fine after the few 100s milliseconds of loading. I still believe this is just Twitch doing some bandwidth savings and having to quick reload the stream on tab re-focus. I'll let the issue open a bit to see if other people can reproduce and debug what's happening network-wise

I stand corrected then. It was pure coincidence that I noticed this when the extension was installed.

I think what happened was, when I didn't have it installed, nowhere did I even attempt to open a new twitch tab with the stream being muted. And in addition, when I turned off the extension, never attempted to open a new twitch tab with the stream being muted and thought it was resolved.

You are probably correct in saying it's a thing from Twitch themselves. But it's odd that they would implement something that could easily be bypassed by unmuting and muting LOL!

Apologies, this issue has nothing to do with the extension! But I have appreciate the involvement, and I have learnt from this experience!

younesaassila commented 1 year ago

No problem, thanks! By reporting issues we all learn something new!