younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.45k stars 29 forks source link

Make VPNs and other proxy extensions work with the extension (Chrome) #165

Closed younesaassila closed 1 year ago

ghost commented 1 year ago

Blocked by the implementation & rollout of Manifest V3.

Ashesh3 commented 1 year ago

One possible workaround is to add a quick toggle to the extension, if toggled off, It will give proxy controls back to Chrome using an implementation similar to how SwitchyOmega does: SwitchyOmega/proxy_impl_settings.coffee#L10 . Note that this is different from just setting the proxy to DIRECT, in that case this extension would force disable other proxy extensions.

The intention of getting TTV lol pro work ALONG with other proxy extension (both enabled and on) is not possible due to the nature of how pacScript work. This extension will conflict with other extensions trying to control the proxy settings. Such conflicts are caused by the design of the Chrome browser and thus cannot be avoided. When "TTV lol pro" has a higher priority, only then it can be configured to voluntarily give back the control by using the linked code snipped above. Re-installing this extension should raise its priority, providing a possible workaround.

younesaassila commented 1 year ago

@Ashesh3 Thanks for your help! I'll try to see if I can automate this on/off switching by checking for opened Twitch tabs. If none it goes back to OG proxy settings.

Sad to know that using proxy extensions at the same time is not possible. Perhaps if another extension is using a pacScript I can combine both, but yeah can't do for other types of proxy configs.

younesaassila commented 1 year ago

Fixed for next release

Makezu90 commented 1 year ago

so only on chrome? release page say: chromium based browsers should be fixed if im not understand something wrongly, but on opera gx still can't use same time ttv lol pro & Proxy SwitchyOmega.