In Chrome, clicking the extension icon should show which proxy is being used.

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.

GNU General Public License v3.0

1.39k stars 28 forks source link

In Chrome, clicking the extension icon should show which proxy is being used. #170

Closed DaveKap closed 1 year ago

DaveKap commented 1 year ago

It was a really nice feature, back in the v1 days, being able to see which proxy was being used on a stream because at least then we could live-debug whether our proxies were or weren't working and seeing whether or not fallback priority was working. It seems we cannot do that in v2. Is it possible to bring this nice feature back?

thinkpad4 commented 1 year ago

I too would like this feature added please.

younesaassila commented 1 year ago

Added help wanted label since I couldn't figure out any Manifest V3-compatible way of achieving this with the chrome.proxy API. Workarounds like implementing a custom fallback system where you'd add a chrome.webRequest.onBeforeRequest listener to set proxy settings to 1 proxy and catch if the proxy is offline with chrome.webRequest.onErrorOccurred to figure out the proxy being used don't work with Manifest V3 due to the removal of webRequestBlocking.

I would highly appreciate the help from other developers! Is this even possible with chrome.proxy?

ghost commented 1 year ago

Added help wanted label since I couldn't figure out any Manifest V3-compatible way of achieving this with the chrome.proxy API. Workarounds like implementing a custom fallback system where you'd add a chrome.webRequest.onBeforeRequest listener to set proxy settings to 1 proxy and catch if the proxy is offline with chrome.webRequest.onErrorOccurred to figure out the proxy being used don't work with Manifest V3 due to the removal of webRequestBlocking.

I would highly appreciate the help from other developers! Is this even possible with chrome.proxy?

There is no way of doing this. Even if it was possible, V2 has already been bypassed.

DaveKap commented 1 year ago

Is Manifest V3 such an issue when folks are using Brave to keep V2 intact? Are V2-allowable Chromium builds too low of a market share to bother with?

younesaassila commented 1 year ago

@DaveKap The Chrome Web Store only allows MV3 extensions. Also let's be honest, other browser vendors will probably end MV2 support at some point too.

younesaassila commented 1 year ago

Alright I found a way to get which proxy was used for a specific request. The channel name => video-weaver URLs mapping is still not implemented. At least debugging logs have been improved on Chrome

younesaassila commented 1 year ago

👀

younesaassila commented 1 year ago

Alright closing this since it has been implemented in 2.1.0 (i.e. the next release) :D