search

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.39k stars 28 forks source link

Incomptaible with FrankerFaceZ emotes in Firefox #193

Closed VibeEly closed 1 year ago

VibeEly commented 1 year ago

Describe the bug

FrankerFaceZ emotes don't appear if TTV LOL PRO is enabled.

FrankerFaceZ is an extension for Twitch. They also host a library of Twitch emotes, similar to BTTV and 7TV. To avoid confusion: FrankerFazeZ - the extension. FrankerFaceZ emote library - the emotes hosted by FFZ staff. Notably separate from BTTV and 7TV emotes.

https://www.frankerfacez.com/emoticons/

To Reproduce Steps to reproduce the behavior:

  1. Install Firefox on Windows 11.
  2. Install FrankerFaceZ.
  3. Install TTV LOL PRO from this GitHub using the "Temporary" method.
  4. Attempt to use emotes from the FFZ library. BTTV and 7TV emotes work. FFZ library emotes do not work.
  5. Turn TTV LOL Pro extension ON and OFF. The FFZ emotes will work when TTV LOL PRO is off.

Expected behavior FFZ library emotes should work.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context I brought up the problem with the FrankerFaceZ team on their discord, and told them I would file a bug report here.

I've attached 2 screenshots. One shows the emotes not appearing in the emote menu, the other shows them appear (when TTV LOL PRO is disabled). Screenshot 2023-06-14 235725 Screenshot 2023-06-15 002830

zGato commented 1 year ago

Tried to reproduce. My browser directly crashes using FrankerFaceZ alone. With TTV LOL PRO enabled yeah, FFZ are not showing, but without it the browser just crashes lmao. Firefox Dev Edition @younesaassila script probably. Chrome works just fine.

younesaassila commented 1 year ago

Thanks for the report. It was an error with the injected script indeed. Fixed for the next release :)