search

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.39k stars 28 forks source link

bug: Number of proxied requests stops increasing #216

Closed KammererTob closed 11 months ago

KammererTob commented 1 year ago

Describe the bug The number of proxied requests in the options overlay seem to stop increasing after a certain time/action

To Reproduce Not entirely sure how to reproduce, but it might be related to either switching tabs, moving chrome in the background or moving chrome/tab on to a second monitor

Expected behavior The number should increment for every proxied request

Desktop (please complete the following information):

zGato commented 1 year ago

This seems to be reproducible if you get a ghost ad or you make your player get a new streamer.m3u8 request (stream in the background for too long and you tab back in)

Do you have uBlock Origin installed?

KammererTob commented 1 year ago

Yes i have uBlock Origin installed and active on Twitch

younesaassila commented 1 year ago

Has anyone been able to consistently reproduce this issue? It's possible the bug is caused by the function that clears proxy settings when all Twitch tabs are supposedly closed.

younesaassila commented 1 year ago

I've opened a small PR (#222) that potentially fixes this. Can anyone confirm if that is the case?

(Just a small PR, still on my indefinite break from actively working on the project)

KammererTob commented 1 year ago

I will build from source and try if i can still reproduce this. It was a bit random before so i might not get back with 100% confirmation tho.

KammererTob commented 11 months ago

doh. I am an idiot. I've built v2 branch instead of your PR branch. Will do it again with the correct branch and test

younesaassila commented 11 months ago

Fix should be working :)