younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.39k stars 26 forks source link

Opening Twitch clip in new tab does not load in Firefox #245

Closed tugboat-maguire closed 10 months ago

tugboat-maguire commented 10 months ago

Describe the bug When opening twitch clip in new tab, the clip that is opened first does not load.

To Reproduce Steps to reproduce the behavior:

  1. enable ttv-lol-pro addon in firefox
  2. open a twitch clip in a new tab
  3. twitch clip page will never load.

Expected behavior Twitch clip will play

Screenshots Screencast from 2023-09-01 13-37-41.webm

Desktop (please complete the following information):

Smartphone (please complete the following information): N/A

Additional context happens on both windows 10 and linux. only first opened clip will fail to load. opening clip again will make it load successfully.

zGato commented 10 months ago

Can't repro using FF Dev (118.0b3) so perhaps a FF bug? Younes may be able to discuss further, as it is most likely due to the script injection used for FF optimizations. https://i.imgur.com/93SGCrA.mp4

tugboat-maguire commented 10 months ago

i found i could only reproduce the issue when this addon is installed: https://addons.mozilla.org/en-US/firefox/addon/redirect-shorts-to-youtube/

not sure how it is conflicting with ttv-lol-pro but ill close issue.