search

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.45k stars 29 forks source link

Whitelisting via tab analysis for chromium #256

Closed lukefanning closed 1 year ago

lukefanning commented 1 year ago

After noticing that whitelisting only worked on Firefox, I really wanted the same feature for Chrome.

Ran into the insurmountable issue of being limited by Chrome's proxy security and the proxy auto-config script.

So I decided to come up with a compromised solution that involves basing whether to enable proxying based on the twitch tabs you have open. If you only have whitelisted tabs open then the proxy will not be enabled but if even one tab is open that isn't whitelisted then the proxy will be enabled.

Feels free to close this PR if this isn't a suitable solution for you guys :)

younesaassila commented 1 year ago

This seems like a good compromise. I'll look more into it once I have a bit more time to work on this project. In the meantime, could you run npm run lint:fix to fix linter errors? Thanks :)

younesaassila commented 1 year ago

I checked out your PR in a branch on this repo, fixed the few issues I found, and merged into the v2.2.0 branch. Thanks for your contribution :)

zGato commented 1 year ago

@lukefanning Please DM me on Discord if you want to get the donators proxies. Thank you for your contribution ❤️ zgato_