search

younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.46k stars 30 forks source link

Show update notification for Chrome users in popup #27

Closed younesaassila closed 1 year ago

younesaassila commented 1 year ago

Chrome users currently have no way to know a new version of the extension is available.

Adding a notification in the extension's popup could be a good idea to fix this. Perhaps fetching the same manifest Firefox uses and parsing it on the runtime.onStartup event?

(Please test if opening multiple browser windows would send the request multiple times. The goal here is to send as few requests as possible, ideally once on browser process startup, where we could even go further and store a lastUpdateCheck timestamp and only fetch the manifest if more than a day elapsed since last check).

Parsing the manifest could be as easy as listing all version number keys and checking if one of them is greater than current extension version. (Check out semver-compare on npm)

Edit: Forgot to say update notification should include a link to the latest release on GitHub

younesaassila commented 1 year ago

Done, will be merged with v1.5.0