younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.43k stars 29 forks source link

TTV LOL PRO prevents me from following streamers. #341

Open zkreeg opened 1 month ago

zkreeg commented 1 month ago

Describe the bug When TTV LOL PRO is enabled, it prevents me following Twitch Streamers.

To Reproduce Enable TTV LOL PRO. Click the Follow button. Refresh the page/tab. The follow button is then deactivated.

I can work around this by disabling TTV LOL PRO. Then clicking the follow button. Then re-enabling TTV LOL pro.

Expected behavior I expect the extension to not deactivate the follow button.

Screenshots n/a

Desktop (please complete the following information):

ibillingsley commented 1 month ago

I think this happens in Firefox specifically when opening streams in a new background tab, but it's not consistent. It also prevents FFZ from loading. The window.onload event never fires, document.readyState stays "loading" forever.

For me refreshing the page usually fixes the issue without needing to disable the extension, but it is quite annoying.

younesaassila commented 1 month ago

Tried to reproduce on Firefox but wasn't able to (my laptop is slow though so perhaps the loading is slow enough to trigger the onload event). Can you guys reproduce the problem with TTV LOL PRO completely disabled from the start? Or is the issue indeed caused by the extension and is not just a Twitch problem?

zkreeg commented 1 month ago

It only occurred when the extension was enabled. As stated in the original post I turned off the extension and had no issues. Once the extension was re-enabled it occurred again on several streams.

ibillingsley commented 1 month ago

I can reproduce on a fresh Firefox profile with only TTV LOL PRO installed. It does not occur with the extension disabled. Happens on both Windows and Linux. Note that the follow button appears to work (heart icon turns solid), but the follow does not actually go through.