younesaassila / ttv-lol-pro

TTV LOL PRO removes most livestream ads from Twitch. This is free, don't expect it to be perfect.
GNU General Public License v3.0
1.43k stars 29 forks source link

Add Octokit to check for GitHub updates on unpacked install. #82

Closed NanoAi closed 1 year ago

NanoAi commented 1 year ago

Github has an API where you can check for updates to a repo with Javascript. API: https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28 Octokit: https://github.com/octokit/core.js

Please add a passive update check that fires maybe once a day so users can stay up to date without having to edit their registry.

PS. How come this isn't on the app store? Project forks not allowed?

younesaassila commented 1 year ago

Thanks for your suggestion!

Github has an API where you can check for updates to a repo with Javascript.

The extension already relies on an update URL for automatic updates. So, there would be no need to use the GitHub API.

Please add a passive update check that fires maybe once a day so users can stay up to date without having to edit their registry.

This feature would require a new build system because the current one builds a unique version for all platforms.

PS. How come this isn't on the app store? Project forks not allowed?

It's because Chrome no longer allows Manifest v2 extensions to be uploaded to their store.


Edit: This could be a toggle option in the extension's settings page. Something along the lines of "Notify me of new updates in the popup" (disabled by default of course, so that users with auto updates don't see this banner in the popup)