search

younginnovations / aidstream

AidStream is a platform for small and medium size NGOs to publish their aid data in IATI standard.
http://aidstream.org
MIT License
20 stars 13 forks source link

Missing rule of IATI DAC policy marker significance #314

Closed amy-silcock closed 4 years ago

amy-silcock commented 4 years ago

Hi AidStream,

There's a rule in IATI v2 for the @significance attribute within the <policy-marker> element:

An OECD DAC CRS code indicating the significance of the policy marker for this activity. This attribute MUST be used for all OECD DAC CRS vocabularies.

This value must be of type xsd:string.

This value must be on the PolicySignificance codelist.

@significance must be present if @vocabulary=’1’ or not(@vocabulary)

Currently, there's no warning or error message that alerts a user if they haven't added a 'significance' if they have declared 'vocabulary = 1' or 'no vocabulary' when adding a policy-marker.

See: http://reference.iatistandard.org/203/activity-standard/iati-activities/iati-activity/policy-marker/

Please could this be added?

sonikabaniya commented 4 years ago

Hi Amy,

Hope you are doing fine! Thank you for pointing this out. We missed this validation during development. This issue is being fixed currently and we will let you know after it's done.

Much thanks!

Kind Regards, On behalf of AidStream team Sonika

amy-silcock commented 4 years ago

Great, thanks Sonika!

sonikabaniya commented 4 years ago

Amy, this issue has been fixed. You can check it from your side as well.

amy-silcock commented 4 years ago

That's looking great! Thank you for adding this in.