search

younglo / cyanogenmod4milestone

Automatically exported from code.google.com/p/cyanogenmod4milestone
0 stars 0 forks source link

toggle led flashlight widget toggle full brightness also #192

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Toggle led flashlight widget from notification bar

What is the expected output? What do you see instead?

Led flashlight get triggered but screen goes fullbrightnes also

What version of the product are you using?

0.3

Please provide any additional information below.

Toggle automatic backlight off before toggling led flashlight to fix issue. 
This should be made automatically in one step by ledflashlight widget. 
Preferably with appling automatic backlight state levels after turning it off.

Original issue reported on code.google.com by mogil...@gmail.com on 5 Nov 2010 at 11:19

GoogleCodeExporter commented 8 years ago 
What brightness level do you suggest to be set while the flashlight is on?

In the meanwhile, until this issue is resolved, do you have the "Allow light 
decrease" option (CyanogenMod settings>User interface>Automatic backlight) 
enabled?

Original comment by kabal...@gmail.com on 6 Nov 2010 at 12:15

GoogleCodeExporter commented 8 years ago 
(there's no single auto level off mode - there's the auto level mode, and then 
there are certain specific brightness levels to be set. What level is the best 
value for all occasions, when automatic should be turned off? E.g. when i need 
to investigate some dark corners of my citroen engine, otherwise in full 
sunlight? When I turn the flashlight on and the display then dims, I will have 
a hard time to turn the flashlight off, when don't see anything on the dimmed 
display because of the sunlight...)

Original comment by kabal...@gmail.com on 6 Nov 2010 at 12:35

GoogleCodeExporter commented 8 years ago 
Simply put brightness shouldn’t hanged at all when you toggle flash light 
widget. Brightness levels should be set to value from auto-brightness before 
flashlight toggle. That’s what I try to say earlier with my horrible English.

Even simple setting 20 to brightness levels get you covered with 99% of the 
cases. Citroen engine issue can be addressed by allowing shake to toggle 
auto-brightness on and flashlight off. This will cove you in 100%. 

I have try “Allow light decrease”  with different decrease hysteresis 
percentage. Not sure when it trigger.

Original comment by mogil...@gmail.com on 6 Nov 2010 at 6:43

GoogleCodeExporter commented 8 years ago 
Thanks for your input.
So the best way seems to be to make a change in the auto-brightness code to 
check whether the flashlight is on or off (to keep updating the brightness 
levels only when the flashlight is off).
It will be included in the next build.

Original comment by kabal...@gmail.com on 8 Nov 2010 at 2:19

GoogleCodeExporter commented 8 years ago

Original comment by kabal...@gmail.com on 8 Nov 2010 at 6:27

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
When turn off led flashlight, screen is includes full brightness ?

Im using Update:
8.11.2010 0.03-10.11.08

Original comment by petyo.ts...@gmail.com on 8 Nov 2010 at 9:35

GoogleCodeExporter commented 8 years ago 
I'm not sure if I understand. Please try to explain it more.

Original comment by kabal...@gmail.com on 9 Nov 2010 at 2:20

GoogleCodeExporter commented 8 years ago 
Ok my english is bad sorry :)

When turn on led flashlight all is ok, but when turn off "full brightness 
issue" is present for 10sec then normalize...

Original comment by petyo.ts...@gmail.com on 9 Nov 2010 at 3:48

GoogleCodeExporter commented 8 years ago 
Confirmed.
It's caused by the Light sensor filter enabled - the moving average filter 
works also with the light sensor data from the past thus also from the time 
period when the flashlight has been on.

As I've never experienced any flicker caused by the light sensor on Milestone, 
I've considered the sensor filter redundant (it seems that the sensor data are 
already filtered by the kernel driver), so I haven't tested the flashlight with 
the filter enabled.

Therefore I suggest to turn the filter off as it really seems to not be needed 
on Milestone.

Original comment by kabal...@gmail.com on 9 Nov 2010 at 4:17

GoogleCodeExporter commented 8 years ago 
how to turn the filter off?
p.s thanks for great rom :)

Original comment by petyo.ts...@gmail.com on 9 Nov 2010 at 4:31

GoogleCodeExporter commented 8 years ago 
Settings > CyanogenMod settings > User interface > Automatic backlight > Light 
sensor filter - Enabled (OFF)

Original comment by kabal...@gmail.com on 9 Nov 2010 at 4:35

GoogleCodeExporter commented 8 years ago 
Thank you very much, now work perfect :)

Original comment by petyo.ts...@gmail.com on 9 Nov 2010 at 4:42