R code reorg - Githubissues

youngser / D3M2

0 stars 0 forks source link

R code reorg #1

Closed disa-mhembere closed 7 years ago

disa-mhembere commented 7 years ago

From a software dev position I've done something unmaintainable by producing redundant R code in the python wrapper. I would like to suggest the following reorg:

separate each R script into 2 files:
1. An interface script with an uncalled function
2. A command line callable script that is a user facing script

I've done this for oocase -- see SRC. It leads to very simple, short and most importantly maintainable wrappers see python

Thoughts?

youngser commented 7 years ago

Agreed! I will try to do that for the rest of the primitives and the three other ones.

BTW, is this related to what we talked about on the board yesterday? This is nothing to do with the TA2 API Interface, which we won't know until it's finalized, right?

disa-mhembere commented 7 years ago

Nope it is unrelated to TA2, but will just help to keep everything maintainable :)

On Sep 12, 2017 10:09 AM, "youngser" notifications@github.com wrote:

Agreed! I will try to do that for the rest of the primitives and the three other ones.

BTW, is this related to what we talked about on the board yesterday? This is nothing to do with the TA2 API Interface, which we won't know until it's finalized, right?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/youngser/D3M/issues/1#issuecomment-328861347, or mute the thread https://github.com/notifications/unsubscribe-auth/ABtfJBQjWhax3dkwZ_LS7N4vwU5rEZHqks5sho3ogaJpZM4PUIgP .