Missing definition types for components

youngtailors / react-silk

Seamless components that work on both react web and native

https://youngtailors.github.io/react-silk

MIT License

17 stars 4 forks source link

Missing definition types for components #61

Closed hieuhani closed 5 years ago

hieuhani commented 5 years ago

./dist ├── react-silk-ui.es.js └── react-silk-ui.js

0 directories, 2 files

dacsang97 commented 5 years ago

Do you run tsc after build?

dacsang97 commented 5 years ago

What the command you use to build?

"prebuild": "rimraf dist && tsc",
"build": "rollup -c",

I had checked package.json, we have tsc before build.

hieuhani commented 5 years ago

Not yet, I just use yarn dev to develop. The error: TypeScript error: Could not find a declaration file for module 'react-silk-ui'. '/Users/hieuhani/Code/react-silk/packages/react-silk-ui/dist/react-silk-ui.js' implicitly has an 'any' type. threw

hieuhani commented 5 years ago

If it needs to be, please specify in the docs

dacsang97 commented 5 years ago

I fixed this in #63