Lyric Preview falls back to default theme after leaving the "Edit Theme" Window with OK, Cancel or 'X'

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Select a song (add to schedule)
2. Open the Theme selection and select any (except the default theme)
3. Preview is now displayed with the selected theme
4. Open theme selection again and click on Edit
5. Leave the edit theme window, either by click on OK, Cancel or X
6. The Lyric preview is now displayed with the default theme

Editing a Theme should not affect the theme selection.
If editing the active theme, i´d expect the preview to update not to fall back 
to a certain theme...

The problem can be reproduced with 2014.0 (Windows) and 2014.1 2014-06-17 
(cross platform)

Please provide any additional information below.

Original issue reported on code.google.com by MisterSi...@gmail.com on 17 Jun 2014 at 6:22

Attachments:

• 2014.x_LeavingEditThemeWindow.jpg

[GoogleCodeExporter]

Original comment by berry...@gmail.com on 17 Jun 2014 at 10:09

• Changed state: Accepted
• Added labels: Milestone-Release2014.1

[GoogleCodeExporter]

Original comment by berry...@gmail.com on 17 Jun 2014 at 10:14

[GoogleCodeExporter]

Original comment by bengoodw...@gmail.com on 17 Jun 2014 at 3:10

[GoogleCodeExporter]

Original comment by bengoodw...@gmail.com on 17 Jun 2014 at 3:13

• Changed state: Started

[GoogleCodeExporter]

Hi MisterSimon86,

Great observation. I can reproduce it and it seems that clicking 'Edit' on 
*any* theme in that panel has the same effect.

Looking at fixing it now.

Original comment by bengoodw...@gmail.com on 17 Jun 2014 at 3:23

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

This issue was closed by revision 626860575664.

Original comment by bengoodw...@gmail.com on 17 Jun 2014 at 5:42

• Changed state: Fixed

[GoogleCodeExporter]

Hi Simon,

I believe this is now fixed, if you get a chance to test I'd appreciate it! 

Thanks for your feedback, keep it coming!

Ben

Original comment by bengoodw...@gmail.com on 17 Jun 2014 at 5:44

[GoogleCodeExporter]

Hy Ben!
I tested the bugfix...

If there is The default Theme and A SINGLE user theme,
your bugfix is working. Editing the user created theme works properly.

But if there is more than one user theme created there is a similar problem,
with the difference, that leaving the edit theme window does not lead to the 
default theme anymore, but the "newest" theme will be activated.

hopefully the screenshot can give a better description:

Original comment by MisterSi...@gmail.com on 18 Jun 2014 at 11:12

Attachments:

• EditTheme_LastSelected.jpg

[GoogleCodeExporter]

This issue was closed by revision 52c8f12c31ff.

Original comment by bengoodw...@gmail.com on 19 Jun 2014 at 11:30

[GoogleCodeExporter]

Thanks Simon! These Theme Panel bugs don't want to die! This should have done 
it.

Original comment by bengoodw...@gmail.com on 19 Jun 2014 at 11:31

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Hy Ben!
Thank you for your effort on this, very tricky, issue.

With the new bugfix the Theme does not fall back =)
BUT
- In the select theme Window there is no theme selecte (Screenshot)
- Changes on the active theme have no effect on the preview until the theme is 
re-selected

Sorry for bothering you again with this stuff =)
Simon

Original comment by MisterSi...@gmail.com on 19 Jun 2014 at 10:15

Attachments:

• EditTheme_20140619_1927.jpg

[GoogleCodeExporter]

This issue was closed by revision 5cd492b1eedd.

Original comment by bengoodw...@gmail.com on 20 Jun 2014 at 9:49

[GoogleCodeExporter]

Hi Simon,

Thanks for this, despite how infuriating it is! I believe that should all be in 
order. Can you run it through your rigorous tests again?

Thanks,
Ben

Original comment by bengoodw...@gmail.com on 20 Jun 2014 at 9:52

[GoogleCodeExporter]

Hy Ben!

Bugfix is working =) well done!

Simon

Original comment by MisterSi...@gmail.com on 20 Jun 2014 at 10:32