youp911 / quelea-projection

Automatically exported from code.google.com/p/quelea-projection
0 stars 0 forks source link

LiveView and StageView can´t display a song if the main and translated chords differ too much #257

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Adding a song containing chords and translation (e.g. German) to schedule
2. Select the translation
3. GoLive
4. Song is displayed with main and translated lyrics and the english chords
   See first Screenshot
5. If the chords differ too much (e.g. in some cases the german version misses 
some) quelea can´t display the song properly

What is the expected output? What do you see instead?
Fall back to the main lyric´s chords.

What version of the product are you using? On what operating system?
2015.0 2014-10-20

Please provide any additional information below.

Original issue reported on code.google.com by MisterSi...@gmail.com on 21 Oct 2014 at 3:26

Attachments:

GoogleCodeExporter commented 8 years ago
This is an interesting one in terms of a fix. Since that chord line is blank in 
the translation, it effectively terminates that section - meaning Quelea "sees" 
a translation of verse 1 with only the first line translated.

The problem is if someone *had* genuinely just provided a translation for the 
first line, blindly tacking the next section on would not be the right thing to 
do, and could be confusing!

However, Quelea should definitely display the first line rather than nothing at 
least - this is now fixed in the nightly.

Also fixed is I believe the reason for this occurring in the first place, which 
is that chords are passed to the translator to translate even though they 
shouldn't be - meaning the translator will try to parse and translate the 
chords, sometimes returning a blank line. So chord lines are now ignored by the 
translator in the latest nightly.

If this doesn't help then let me know!

Original comment by berry...@gmail.com on 21 Oct 2014 at 11:04

GoogleCodeExporter commented 8 years ago
1: "However, Quelea should definitely display the first line rather than 
nothing at least - this is now fixed in the nightly."
=> I tested this bugfix and it´s working!

2: "So chord lines are now ignored by the translator in the latest nightly."
=> I haven´t seen a change on the translator, the german lyrics still contain 
chords when adding a new German (Deutsch) translation

Original comment by MisterSi...@gmail.com on 22 Oct 2014 at 8:00

GoogleCodeExporter commented 8 years ago
Sorry, by "ignore chords" I mean that they will appear the same as they do in 
the default lyrics rather than being translated or removed :-)

Original comment by berry...@gmail.com on 22 Oct 2014 at 8:23

GoogleCodeExporter commented 8 years ago
oh, sry.
So in this case, they are ignored.
Bugfix works

Original comment by MisterSi...@gmail.com on 22 Oct 2014 at 9:28