search

your-tools / tsrc

Manage groups of git repositories
https://your-tools.github.io/tsrc/
BSD 3-Clause "New" or "Revised" License
206 stars 36 forks source link

Remove attrs dependency #420

Open philfry opened 2 months ago

philfry commented 2 months ago

Hi,

since attr is no longer used since v2.5.0, would you consider removing attrs from the dependencies?

https://github.com/your-tools/tsrc/blob/6f2ffe29e93d179c48d1f2ff8a65e3e839c09167/poetry.lock#L3

https://github.com/your-tools/tsrc/blob/6f2ffe29e93d179c48d1f2ff8a65e3e839c09167/pyproject.toml#L22

Because the built package still includes Requires-Dist: attrs (>=19.3.0,<20.0.0).

Thanks & kind regards,

Philippe

lomnido commented 2 months ago

hi Philippe,

I have been checking into this issue and found out that:

flake8-bugbear

still require 'attrs' package. And therefore Poetry will include such dependency even if you remove it from 'pyproject.toml' And without flake8-bugbear the Linters checks cannot be performed. While Linters checks are NOT required to run 'tsrc', it is part of the project's code checks.

So in order to get rid of 'attrs' dependency, you need to throw away (related) checks.

This issue may require further consideration.

philfry commented 2 months ago

I see, thanks for your evaluation.

Well, at least flake8-bugbear==21.4.3 is fine with a current attrs version (24.2.0 atm) :smiley:

lomnido commented 2 months ago

Yes, I have noticed that 'attrs' used are set to older version which is not good. We should fix that in next update.

lomnido commented 2 months ago

updating project files: bumping 'attrs' to '24.2.0' since commit: 33909073dd1a31f4b38bfbc8c1fc21bd26bd9094