search

yourPISD / yourpisd

Android app to access myPISD (Plano Independent School District grades portal)
MIT License
2 stars 4 forks source link

Modernize tabs? (material design) #14

Open sid-kap opened 7 years ago

sid-kap commented 7 years ago

Putting this up as a possible to-do. I don't know that much about Android UI, so I might be wrong about some of this stuff.

We originally used SlidingTabLayout and SlidingTabStrip because the built-in Android tab pager required all the tabs to fit horizontally on the screen. In ClassSwipeActivity, we have 6-7 tabs, so we needed a pager that allowed more tabs than could fit horizontally on the screen.

This may no longer be necessary. It looks like the Android Design Support Library now supports scrollable tabs (see the "Tabs" section).

image

Should we switch to this style? (By the way, I took the image from this tutorial.)

ritu99 commented 7 years ago

Would this implementation mean switching the views over to fragments instead of the current implementation?

sid-kap commented 7 years ago

I'm not too knowledgeable about this (Han built the UI, for the most part), but aren't we already using fragments?

I thought that in both MainActivity and ClassSwipeActivity, each tab is its own fragment.

ritu99 commented 7 years ago

My bad, I seem to have skipped over it!