search

yourWaifu / is-your-waifu-legal

Check if your waifu is legal or not
https://yourwaifu.dev/is-your-waifu-legal/
MIT License
104 stars 57 forks source link

Create Emilia - Redone #48

Closed Alcala09 closed 3 years ago

Alcala09 commented 3 years ago

This is redone so it doesn't replace anybody

yourWaifu commented 3 years ago

can you put the .json to the end of the filenames, also you don't need to redo a pull request just push changes the branch. they should also be lower case

yourWaifu commented 3 years ago

also I just added the hacktoberfest tag, can you help me make sure it's counting your pull request and how many times it counted?

Alcala09 commented 3 years ago

also I just added the hacktoberfest tag, can you help me make sure it's counting your pull request and how many times it counted?

It has requested for Emilia twice, the second one is the improved one with the changes you requested. For Mai Sakurajima, I do not see her in the main pull request page.

Alcala09 commented 3 years ago

Are there any other issues with the JSON script?

yourWaifu commented 3 years ago

it's not a script, but I'll look over it like usally, I think I need an automated tool for this.

yourWaifu commented 3 years ago

ok here comes the screenshots image image

I'll point out the issues.

yourWaifu commented 3 years ago

more screenshots image image

yourWaifu commented 3 years ago

There's a few things I want you to add to the notes, it says that she was frozen at one point, I feel that's an important detail that describes Emilia's age.

Alcala09 commented 3 years ago

Alright made a note about Emilia being frozen for 100 years, and capitalized the names (not for the json)