search

yourWaifu / sleepy-discord

C++ library for the Discord chat client. Please use Rust for new bots
https://yourWaifu.github.io/sleepy-discord/
MIT License
708 stars 93 forks source link

SLEEPY_VCPKG confusion #270

Closed uis246 closed 1 year ago

uis246 commented 1 year ago

For some reason find_package is hidden behind USE_VCPKG flag. Why? Find_package isn't something vcpkg-specific, it's part of cmake.

uis246 commented 1 year ago

https://github.com/yourWaifu/sleepy-discord/blob/master/sleepy_discord/CMakeLists.txt#L204 This raises more questions. Why hide this at all?

yourWaifu commented 1 year ago

It's not hidden. The tutorial uses add subdirectory, but to use find_package cmake needs to know how to find said library. So you need a cmake that finds the package. I personally don't want to deal with that mess and so I lock it behind VCPKG.

uis246 commented 1 year ago

I looked into cmake/Modules. Yep, no modules for those, sorry.

Still install() is unrelated to VCPKG