youradds / hestiacp-autoconfig-email-discovery

A sample script for setting up autoconfig/autodiscove email settings for mail servers
5 stars 2 forks source link

Using local dns.. #1

Open jult opened 1 year ago

jult commented 1 year ago

syntax error at /installer/add-autodiscover.cgi line 132, near "} else" syntax error at /installer/add-autodiscover.cgi line 138, near "}" Execution of /installer/add-autodiscover.cgi aborted due to compilation errors.

jult commented 1 year ago

and another one when deleting the else statement..;

sed: can't read /home/userx/web/domainnamex/public_html/mail/config-v1.1.xml: No such file or directory

youradds commented 1 year ago

How are you running that script? I'm a bit confused, as line 132 is:

v-restart-service 'nginx' '';

So not } else at there

jult commented 1 year ago

OK, for the last one; You left out the .xml for that file. Also noteworthy; autodiscover.json has a different setup for smtp as autodiscover.xml (wrong port, you should use 587 and STARTTLS).

youradds commented 1 year ago

Hi,

config-v1.1.xml should be in the /mail folder:

https://github.com/youradds/hestiacp-autoconfig-email-discovery/tree/main/mail

That is copied over via:

cp -fr /installer/mail/* /home/$username/web/$domain/public_html/mail/;

Did you put the files in /installer , or another folder? Its important its in the /installer folder (at top level), otherwise that copy won't work

Also noteworthy; autodiscover.json has a different setup for smtp as autodiscover.xml (wrong port, you should use 587 and STARTTLS).

Thanks - I've fixed that up and pushed an update

youradds commented 1 year ago

I have just released an update that checks you are in the right folder:

    # check we are in the right folder (otherwise the copy of files won't work)
    if ($0 ne "/installer/add-autodiscover.cgi") {
        print "Please run this from the /installer directory!\n";
        exit;
    }
dpnx-nudra commented 1 month ago

Hi, I've the same error. I just did:

root@oc00:~# mkdir /installer root@oc00:~# mv hestiacp-autoconfig-email-discovery/* /installer/ root@oc00:~# vi /installer/add-autodiscover.cgi #change dns type to local root@oc00:~# sudo perl /installer/add-autodiscover.cgi nudra.cl myuser syntax error at /installer/add-autodiscover.cgi line 140, near "} else" syntax error at /installer/add-autodiscover.cgi line 146, near "}" Execution of /installer/add-autodiscover.cgi aborted due to compilation errors.

Maybe I'm missing some step?

youradds commented 1 month ago

@dpnx-nudra it looks like a bug was introduced. I've fixed it up now, so it should work:

https://github.com/youradds/hestiacp-autoconfig-email-discovery/blob/main/add-autodiscover.cgi

I can't remember how to create a new version, and don't have time to play - but that should do it :)