Added default options OLWIDGET_DEFAULTS

yourcelf / olwidget

Javascript library to replace textareas that contain WKT data with editable OpenLayers maps, and a django app using it for django forms and admin.

Other

91 stars 44 forks source link

Added default options OLWIDGET_DEFAULTS #49

Closed dyve closed 13 years ago

dyve commented 13 years ago

Optional default settings OLWIDGET_DEFAULTS are read from settings.py
get_options in utils.py takes options parameter, merges with default settings and returns merge
widgets.py and forms.py use utils.get_options

yourcelf commented 13 years ago

Thanks for these edits, and apologies for the long delay in my response. The changes look good. I pulled this and just pushed it to the master here.

I also added the code cleanup changes from your earlier pull request. Thanks!

dyve commented 13 years ago

Thanks Charlie! I'll see what I can do next!

yourcelf commented 13 years ago

Hey,

In the latest commit I've renamed this option OLWIDGET_DEFAULT_OPTIONS, which is a little more specific than OLWIDGET_DEFAULTS, and keeps at least some consistency with the "options" name.

best, Charlie

dyve commented 13 years ago

Seems like the right thing, thanks for the heads up

On Mon, Mar 28, 2011 at 16:49, yourcelf reply@reply.github.com wrote:

Hey,

In the latest commit I've renamed this option OLWIDGET_DEFAULT_OPTIONS, which is a little more specific than OLWIDGET_DEFAULTS, and keeps at least some consistency with the "options" name.

best, Charlie

Reply to this email directly or view it on GitHub: https://github.com/yourcelf/olwidget/pull/49#issuecomment-926301