layer is not defined in layer.setUndoButtonStates();

[elpaso]

olwidget.js (line 1218) layer is not defined layer.setUndoButtonStates();

Missing "ctrl" ?

/*
 * Our editing toolbar.
 */
olwidget.EditingToolbar = OpenLayers.Class(OpenLayers.Control.Panel, {
    onClick: function(ctrl, evt) {
        // Keep undo button states
        OpenLayers.Event.stop(evt ? evt : window.event);
        this.activateControl(ctrl);
        // Missing ctrl ?
        ctrl.layer.setUndoButtonStates();

    },
});

[elpaso]

... it seems like my patch does not work in all situations (for instance: Clear all).

The bug remains: layer is not defined

try this:

/*
 * Our editing toolbar.
 */
olwidget.EditingToolbar = OpenLayers.Class(OpenLayers.Control.Panel, {
    onClick: function(ctrl, evt) {
        // Keep undo button states
        OpenLayers.Event.stop(evt ? evt : window.event);
        // ABP: patched
        this.activateControl(ctrl);
        try {
            ctrl.layer.setUndoButtonStates();
        } catch(e) {
            console.log(e);
        };
    },
});

[yourcelf]

Thanks. Not sure what happened here; but I believe the correct call was "this.layer.setUndoButtonStates()". Please open a new issue if this results in unexpected behavior anywhere.