Open ghost opened 4 years ago
yourduskquibbles
commented
4 years ago I think I remember someone else finding maybe addressed in Adguard Annoyances, from what I remember, this may need a script inject to remove event listener -I will need to research and investigate more when I get the time, I have limited time right now to investigate further so any help from others would be appreciated!
ghost
commented
4 years ago @yourduskquibbles After a bit of testing I found that the uBlock - Annoyances list fixes it with this filter:
reddit.com##body.scroll-disabled:style(overflow: visible!important; position: static!important;)
yourduskquibbles
commented
4 years ago @p4t44 Great! Thanks for looking into the fix - I have added your suggested filter. I should be able to test later today or tomorrow and confirm it is working, but please feel free to also test and let me know if there is still any issue.
ghost
commented
4 years ago @p4t44 Great! Thanks for looking into the fix - I have added your suggested filter. I should be able to test later today or tomorrow and confirm it is working, but please feel free to also test and let me know if there is still any issue.
Yep works perfectly. Cant scroll before force updating the list, can straight after. While testing a came across a heap of other annoyances and put together an imgur album with screenshots and filters. You think you could add them?
Thank you!
Quick edit: im not sure if sub domains need to be specified? Filters for old reddit need to work on both www. and old. reddit.com and filters for new reddit need to work on both new. and www. reddit.com. Is an asterisk required or are these enforced everywhere automatically? Idk.
yourduskquibbles
commented
4 years ago Thanks for update! I will try to take a look at your suggested filters and add them today.
yourduskquibbles
commented
4 years ago @p4t44 for New reddit coronavirus box, cant find a good filter for this.
how about this filter
new.reddit.com,www.reddit.com##div > svg > polygon[points="11.649 9.882 18.262 3.267 16.495 1.5 9.881 8.114 3.267 1.5 1.5 3.267 8.114 9.883 1.5 16.497 3.267 18.264 9.881 11.65 16.495 18.264 18.262 16.497"]:nth-ancestor(3)
That filter looks for the x close button polygon, only thing is it may find other areas of the site with an x close button (I don't use new reddit so don't know if those are used in other parts of the site) and cause inadvertent removal, are you able to test?
Still running through your other reports, no other questions/concerns so far.
yourduskquibbles
commented
4 years ago for New reddit not signed in trending today. Cant find a good filter on my phone again.
How does this filter work
new.reddit.com,www.reddit.com##h2:has-text(/Trending Communities/):nth-ancestor(4) work?
yourduskquibbles
commented
4 years ago All proposed additional filters + a couple others I found.
! Filters for ad_placeholders.txt
! self promo buttons & in-feed ads
new.reddit.com,www.reddit.com##.TopNav__promoButton, .XPromoInFeed, .xPromoAppStoreFooter! Filters for css_companion_filters.txt
! Reddit Premium sidebar box promo
new.reddit.com,www.reddit.com##button:has-text(/Try Now/):nth-ancestor(4)
! Today's Top Growing Communities sidebar box
new.reddit.com,www.reddit.com##div[style='background-image: url("https://www.redditstatic.com/desktop2x/img/leaderboard/banner-background.png");']:nth-ancestor(2)
! Trending Communities sidebar box
new.reddit.com,www.reddit.com##h2:has-text(/Trending Communities/):nth-ancestor(4)
! happening now coronavirus live thread
old.reddit.com##.happening-now-wrap
! email verify nag
reddit.com###redesign-beta-optin-btn, .redesign-beta-optin! Filters for css_style_filters.txt
! pin header to top on new reddit (need more test on mobile for confirm works)
new.reddit.com,www.reddit.com##header[data-redditstyle="true"]:style(position: absolute !important;)
!! Filters for css_style_filters.txt
! pin header to top on new reddit (need more test on mobile for confirm works)
new.reddit.com,www.reddit.com##header[data-redditstyle="true"]:style(position: absolute !important;)
! Additional needed filters after pinning header on new reddit
new.reddit.com,www.reddit.com##div[tabindex="-1"]:style(top: 0 !important;)
new.reddit.com,www.reddit.com###overlayScrollContainer:style(overflow-y: unset !important;)
new.reddit.com,www.reddit.com##div[style^="--comments-overlay-background"]:style(position: absolute !important; background-color: rgba(0,0,0,0) !important;)
new.reddit.com,www.reddit.com##body:style(overflow: auto !important;)
new.reddit.com,www.reddit.com##div[style^="--comments-overlay-background"] > div:style(position: absolute !important; top: 0 !important;)
! pin header to top on mobile new reddit (need more test)
new.reddit.com,www.reddit.com##nav.TopNav :style(position: absolute !important;)
! reddit enhancement suite new reddit floater
new.reddit.com,www.reddit.com##.res-floater-inNavbar:style(position: absolute !important;)! Filters for modal_filters.txt
! email confirm nag box (top of page)
new.reddit.com,www.reddit.com##.email-collection-tooltip__content, .email-collection-tooltip
! happening now coronavirus live thread
new.reddit.com,www.reddit.com##div > svg > polygon[points="11.649 9.882 18.262 3.267 16.495 1.5 9.881 8.114 3.267 1.5 1.5 3.267 8.114 9.883 1.5 16.497 3.267 18.264 9.881 11.65 16.495 18.264 18.262 16.497"]:nth-ancestor(3)
! floating back to top button on sidebar
new.reddit.com,www.reddit.com##div[style="top:calc(100vh - 40px)"]
! email confirm nag box (footer bar)
new.reddit.com,www.reddit.com##h2+button:has-text(/^Add email/):nth-ancestor(10)@p4t44 do you mind testing all of these filters for a day or so and see if they are causing any obvious site breakages before I add them to Web Annoyances Ultralist? You should be able to copy and paste the above code blocks and add them to My Filters - Based on past experience with deploying filters for reddit.com I am a little gunshy on adding so many filters (with wildcards) since reddit.com is such a popular site for users of Web Annoyances Ultralist so don't want to cause any unintentional breakage.
ghost
commented
4 years ago I'll give them a test now but wouldn't be a better idea to give every *.reddit.com? Although it is probably a pretty small minority of Reddit use some subreddits force all internal links to be to np.reddit.com, some subreddits allow filtering of all political posts with a subdomain like nc.reddit.com and nm.reddit.com is used as an unofficial night mode on old reddit. New and old reddit can both be viewed on different subdomains.
ghost
commented
4 years ago ! Filters for ad_placeholders.txt
! self promo buttons & in-feed ads new.reddit.com,www.reddit.com##.TopNav__promoButton, .XPromoInFeed, .xPromoAppStoreFooter
The ##.TopNav__promoButton annoyance is only visible on old reddit. The other filters work fine but they are only for mobile reddit, so the new reddit link isnt required?
! Reddit Premium sidebar box promo new.reddit.com,www.reddit.com##button:has-text(/Try Now/):nth-ancestor(4)
! Today's Top Growing Communities sidebar box new.reddit.com,www.reddit.com##div[style='background-image: url("https://www.redditstatic.com/desktop2x/img/leaderboard/banner-background.png");']:nth-ancestor(2)
This one does not work.
! Trending Communities sidebar box new.reddit.com,www.reddit.com##h2:has-text(/Trending Communities/):nth-ancestor(4)
These new reddit sidebar box ones seem to work well, on new reddit there is not sidebar left at all when not signed in.
! happening now coronavirus live thread old.reddit.com##.happening-now-wrap
Impossible to test as the coronavirus box is gone now, but such boxes are frequent and will come again (and the same filter should block it).
! email verify nag reddit.com###redesign-beta-optin-btn, .redesign-beta-optin
Also needs to work on new.reddit.com
! Filters for css_style_filters.txt
These ones work well in my limited testing.
! Filters for modal_filters.txt
These ones work well again in my limited testing.
ghost
commented
4 years ago 
Another annoyance, RPAN ads in the reddit feed. I think it only happens one day a week, but it is very annoying. https://old.reddit.com/r/uBlockOrigin/comments/ezt8fg/blocking_rpan_from_reddit_feed/ might be useful.
Ill do more thorough testing when I get back to my computer in a few days. Until then testing filters on mobile is hard.
yourduskquibbles
commented
4 years ago I'll give them a test now but wouldn't be a better idea to give every *.reddit.com?
No I don't think so, based on past experience because there are some filters that should only be getting applied to new.reddit.com & www.reddit.com that can cause break on old.reddit.com. See reddit issue topics for a little more background.
Although it is probably a pretty small minority of Reddit use some subreddits force all internal links to be to np.reddit.com, some subreddits allow filtering of all political posts with a subdomain like nc.reddit.com and nm.reddit.com is used as an unofficial night mode on old reddit. New and old reddit can both be viewed on different subdomains.
It would probably good to test on those domains, both logged in and logged out, if able can you provide working links for each subdomain that you know of?
yourduskquibbles
commented
4 years ago ! email verify nag reddit.com###redesign-beta-optin-btn, .redesign-beta-optin
Also needs to work on new.reddit.com
It should be working, can you test again? I believe a filter with just domain reddit.com and no subdomain should work for reddit.com as well as all subdomains (e.g. old.reddit.com www.reddit.com & new.reddit.com) unless there is a specific exception filter for a subdomain created (e.g. new.reddit.com#@##redesign-beta-optin-btn, .redesign-beta-optin)
For the RPAN filter you suggest, I'd rather test & try to come up with a better filter when it is showing up, possible to bump this post when it is showing up?
Thanks for all of the help with this. I've updated all other filters as suggested and a couple other updates, if possible, would you be able to test the updated set of filters below and let me know if working well?
ghost
commented
4 years ago 
Back on my computer and testing, found one issue so far on new reddit. I don't think the shadow should be blocked.
ghost
commented
4 years ago 
Another thing, submit and about are missing from the sidebar.
yourduskquibbles
commented
4 years ago
>
>
Back on my computer and testing, found one issue so far on new reddit. I don't think the shadow should be blocked.
How does adding the following two filters (plus the filters in https://github.com/yourduskquibbles/webannoyances/issues/194#issuecomment-582964023) work for you?
![https://www.redditstatic.com/desktop2x/img/leaderboard/banner-background.png");']:nth-ancestor(2](https://www.redditstatic.com/desktop2x/img/leaderboard/banner-background.png");']:nth-ancestor(2){kind=link}
new.reddit.com,www.reddit.com##div[class*="SubredditVars-r"] > div > div[class$=" "]:style(position: absolute !important; margin-top: -300px !important;)
new.reddit.com,www.reddit.com##div[class*="SubredditVars-r"] > div > div[style*="--fakelightbox-overlay-background"]:style(top: 0 !important;)Another thing, submit and about are missing from the sidebar.
@p4t44 I can't figure out how to reproduce this problem, is it logged in or not logged in? And for a specific subreddit or just on the homepage?
Thanks for continued testing, as you can probably tell by now the reddit site is crazy CSS design structure :)
ghost
commented
4 years ago User reported screenshots
Back on my computer and testing, found one issue so far on new reddit. I don't think the shadow should be blocked.
How does adding the following two filters (plus the filters in #194 (comment)) work for you?
new.reddit.com,www.reddit.com##div[class*="SubredditVars-r"] > div > div[class$=" "]:style(position: absolute !important; margin-top: -300px !important;) new.reddit.com,www.reddit.com##div[class*="SubredditVars-r"] > div > div[style*="--fakelightbox-overlay-background"]:style(top: 0 !important;)
Unfortunately this only creates more issues.
Reddit with no custom filters applied
Reddit with the new filters from your earlier comment
Reddit with the filters from this comment as well as your earlier comment
ghost
commented
4 years ago User reported screenshots
Another thing, submit and about are missing from the sidebar.
@p4t44 I can't figure out how to reproduce this problem, is it logged in or not logged in? And for a specific subreddit or just on the homepage?
Thanks for continued testing, as you can probably tell by now the reddit site is crazy CSS design structure :)
Tried again and it seems that this isn't being caused by the new filters or the webannoyancesultralist at all. Must be another list, sorry.
URL(s) where the issue occurs
https://www.reddit.com/r/firefox/comments/ewvve9/can_we_all_agree_on_the_fact_that_reddit_should/ on Firefox for Android
Describe the issue
On a fresh install of Firefox for Android, after installing uBlock Origin, adding the web annoyances ultralist and visiting a post on reddit I cannot scroll
Screenshot(s)
Not useful as it is a scrolling issue, site visually looks the same wether you can scroll or not.
Versions
Settings
Notes
[Add here the result of whatever investigation work you have done: please investigate the issues you report -- this prevents burdening other volunteers. This is especially true for issues arising from settings which are very different from default ones.]