search

yourduskquibbles / webannoyances

Fix and remove annoying web elements such as sticky headers, floating boxes, floating videos, dickbars, social share bars and other distracting elements.
Creative Commons Attribution Share Alike 4.0 International
1.3k stars 48 forks source link

Scrollbar dissapears on scmp.com #266

Open gasull opened 3 years ago

gasull commented 3 years ago

URL(s) where the issue occurs

https://www.scmp.com/news/hong-kong/health-environment/article/3111107/hong-kongs-entertainment-venues-could-be-forced

Describe the issue

The scrollbar is removed on any article on the South China Morning Post website.

Screenshot(s)

Versions

Settings

[x] Hide placeholders of blocked elements [x] Show the number of blocked requests on the icon [x] Make use of context menu where appropiate [x] I am and advanced user [x] Disable pre-fetching (to prevent any connection for blocked network requests) [x] Disable hyperlink auditing [x] Prevent WebRTC from leaking local IP addresses (all the others disabled)

Notes

I disabled all the other filters and it still happens. I disabled Web Annoyances Ultralist, enabled all the other filters, and the scrollbar was back.

yourduskquibbles commented 3 years ago

@gasull Thanks for reporting, I can not reproduce with various screen widths but I do see double scrollbar on other topic page https://www.scmp.com/coronavirus, so wondering if adding the following filters to your My Filters uBO panel fixes the issue for you on reported example link https://www.scmp.com/news/hong-kong/health-environment/article/3111107/hong-kongs-entertainment-venues-could-be-forced

Filters to add (Make sure to copy all 5 filters including the one to disable the existing filter)

! Disables existing Ultralist scrollbar filter
scmp.com#@##app:not(:has(.home-page-outer)):style(overflow-x: hidden !important; overflow-y: scroll !important; padding-right: 0 !important;)

! new filters to test
scmp.com###app:not(:has(.home-page-outer)):not(:has(.super-section)):style(overflow-x: hidden !important; overflow-y: scroll !important; padding-right: 0 !important;)
scmp.com##.super-section__global-menu-container:style(position: relative !important;)
scmp.com##.super-section .global-menu-content:style(will-change: unset !important; opacity: 1 !important; transform: translate3d(0,0,0) !important; animation: none !important;)
scmp.com##.router-link-active.router-link-exact-active.logo__right-icon-link
yourduskquibbles commented 3 years ago

I just noticed I see you are using firefox esr and uBO legacy (but not the latest version: https://github.com/gorhill/uBlock-for-firefox-legacy/releases, I don't think procedural filters with style filters are fixed yet in legacy version of uBO. The fix to do that is published in the main uBO upstream: https://github.com/uBlockOrigin/uBlock-issues/issues/382

You can try updating to latest legacy firefox ubo build but I still think it may not be fixed in latest based on this open issue on uBO legacy issue tracker: https://github.com/gorhill/uBlock-for-firefox-legacy/issues/259

yourduskquibbles commented 3 years ago

@gasull I will need to download and test firefox ESR with uBO Legacy to figure out a filter you can use until https://github.com/gorhill/uBlock-for-firefox-legacy/issues/259 is added to uBO Legacy.

yourduskquibbles commented 3 years ago

@gasull I installed latest firefox ESR and it looks like this doesn't even use uBO Legacy, I think the version of uBO you are running is just out of date, can you update to latest uBO stable and let me know if you are still having issues? uBlock Origin v1.9.15rc1 version you are using is from 2016 and isn't even offered for download anymore on the uBlock Origin Releases page

RedDragonWebDesign commented 3 years ago

I visited OP's page and I also get a missing scroll bar. I am on uBO dev + Chrome.

I think a modal is turning off the scroll bars. I think the following filters should fix everything.

! fixes lack of vertical scroll bar, caused by a modal
scmp.com##html, body, #app:style(overflow: auto !important;)

! fixes floating toolbar on homepage
scmp.com##.super-section__global-menu-container:style(position: static !important;)
scmp.com##.super-section__header-ad-slot-wrapper:style(padding: 0 !important;)
gasull commented 3 years ago

@yourduskquibbles wrote:

@gasull I installed latest firefox ESR and it looks like this doesn't even use uBO Legacy, I think the version of uBO you are running is just out of date, can you update to latest uBO stable and let me know if you are still having issues? uBlock Origin v1.9.15rc1 version you are using is from 2016 and isn't even offered for download anymore on the uBlock Origin Releases page

I found what is maybe a larger issue. The version I have is the one in Debian 10 (stable):

$ apt search webext-ublock-origin
Sorting... Done
Full Text Search... Done
webext-ublock-origin/stable,now 1.22.2+dfsg-1~deb10u1 all [installed]
  general-purpose lightweight ads, malware, trackers blocker (Web Extension)

But then in Firefox, when going to uBlock Origin preferences → About, the version shown is uBlock Origin v1.9.15rc1.

How can I know if this is

I tried uninstalling and installing the Debian package.

yourduskquibbles commented 3 years ago

I updated the filters again @RedDragonWebDesign are you still getting missing scrollbar after updating Web Annoyances Ultralist?

@gasull I'm not really sure on that question. I don't use Debian or other linux packages so not sure how to interpret what I see in https://packages.debian.org/stable/source/ublock-origin other than it looks like Debian thinks it should be using uBO version 1.22.2 but somehow you are stuck on an older version 1.9.15rc1.

Based on the Debian Package Source Repository (VCS: Git) package listed on https://packages.debian.org/stable/source/ublock-origin Here are firefox install instructions

uBO may also be installed as a Debian package:

  • Firefox 56-: apt-get install xul-ext-ublock-origin
  • Firefox 55+: apt-get install webext-ublock-origin

There is no guarantee the package will be available on your specific platform -- in which case, you will have to install from Firefox Add-ons web site.

If that isn't enough to help, you could try asking over at https://old.reddit.com/r/uBlockOrigin/ or if you've fully investigated and think its a valid bug with uBO deployment on Debian, you could open an issue on uBlock issues Tracker.

yourduskquibbles commented 3 years ago

@gasull Also possibly relevant previous discussion on Debian I found in uBO issue tracking: https://github.com/uBlockOrigin/uBlock-issues/issues/638

This is for Ubuntu maintainers to address, I am not involved in creating packages for Debian/Ubuntu/etc. I am not involved in creating packages for Debian/Ubuntu/etc.

maybe an issue ticket is better opened on the Debian side and not uBO side.

yourduskquibbles commented 3 years ago

@gasull I just installed latest Ubuntu 20.10 on a VM and used the command sudo apt-get install webext-ublock-origin and the version that got downloaded and installed was 1.29.0.

EXPAND CONSOLE OUTPUT ``` ydq@ydq-VirtualBox:~$ sudo apt-get install webext-ublock-origin [sudo] password for ydq: Reading package lists... Done Building dependency tree Reading state information... Done The following additional packages will be installed: webext-ublock-origin-chromium webext-ublock-origin-firefox Suggested packages: ublock-origin-doc Recommended packages: chromium The following NEW packages will be installed: webext-ublock-origin webext-ublock-origin-chromium webext-ublock-origin-firefox 0 upgraded, 3 newly installed, 0 to remove and 7 not upgraded. Need to get 3,774 kB of archives. After this operation, 20.2 MB of additional disk space will be used. Do you want to continue? [Y/n] y Get:1 http://us.archive.ubuntu.com/ubuntu groovy/universe amd64 webext-ublock-origin-chromium all 1.29.0+dfsg-2 [1,881 kB] Get:2 http://us.archive.ubuntu.com/ubuntu groovy/universe amd64 webext-ublock-origin-firefox all 1.29.0+dfsg-2 [1,881 kB] Get:3 http://us.archive.ubuntu.com/ubuntu groovy/universe amd64 webext-ublock-origin all 1.29.0+dfsg-2 [12.0 kB] Fetched 3,774 kB in 1s (3,046 kB/s) Selecting previously unselected package webext-ublock-origin-chromium. (Reading database ... 185367 files and directories currently installed.) Preparing to unpack .../webext-ublock-origin-chromium_1.29.0+dfsg-2_all.deb ... Unpacking webext-ublock-origin-chromium (1.29.0+dfsg-2) ... Selecting previously unselected package webext-ublock-origin-firefox. Preparing to unpack .../webext-ublock-origin-firefox_1.29.0+dfsg-2_all.deb ... Unpacking webext-ublock-origin-firefox (1.29.0+dfsg-2) ... Selecting previously unselected package webext-ublock-origin. Preparing to unpack .../webext-ublock-origin_1.29.0+dfsg-2_all.deb ... Unpacking webext-ublock-origin (1.29.0+dfsg-2) ... Setting up webext-ublock-origin-chromium (1.29.0+dfsg-2) ... Setting up webext-ublock-origin-firefox (1.29.0+dfsg-2) ... Setting up webext-ublock-origin (1.29.0+dfsg-2) ... ```

I have no idea how you get an old developer build try using the above or manually updating to latest build through AMO or installing latest dev build release from the uBlock Origin releases page

RedDragonWebDesign commented 3 years ago

@yourduskquibbles Your updated filters fix the vertical scroll bar. Thank you.

FYI, lots of other annoyances on that website. Flyout video player. Floating bottom banner nagging about how many free articles are left this month. Multimedia pages have a bunch of floating stuff. Maybe worth fixing, maybe not.

gasull commented 3 years ago

Thank you, @yourduskquibbles. I'll look into the possible Debian packaging issue and report it if needed.

The latest filters still hide the sidebar for me, but maybe it's my uBlock Origin version.

@RedDragonWebDesign wrote:

FYI, lots of other annoyances on that website. Flyout video player. Floating bottom banner nagging about how many free articles are left this month. Multimedia pages have a bunch of floating stuff. Maybe worth fixing, maybe not.

Maybe look into how much readership SCMP has to decide if it's worth it. SCMP is probably the main newspaper in Hong Kong.

gasull commented 3 years ago

Replying to myself in case someone lands here from a search: I found that the bug was reported to Debian maintainers over a month ago.

I found what is maybe a larger issue. The version I have is the one in Debian 10 (stable):

$ apt search webext-ublock-origin
Sorting... Done
Full Text Search... Done
webext-ublock-origin/stable,now 1.22.2+dfsg-1~deb10u1 all [installed]
  general-purpose lightweight ads, malware, trackers blocker (Web Extension)

But then in Firefox, when going to uBlock Origin preferences → About, the version shown is uBlock Origin v1.9.15rc1.

yourduskquibbles commented 3 years ago

FYI, lots of other annoyances on that website. Flyout video player. Floating bottom banner nagging about how many free articles are left this month. Multimedia pages have a bunch of floating stuff. Maybe worth fixing, maybe not.

@RedDragonWebDesign Thanks for the example links!

Flyout video filter should be fixed by scmp.com##.youtube-video-container__inner:style(position: relative !important; bottom: unset !important; left: unset !important; padding: 0 !important; width: 100% !important; height: 100% !important; animation: none !important; transform: translateY(0) !important;) which I will add.

multimedia.scmp.com page should be fixed by adding these 3 filters which I will add to Web Annoyances Ultralist

multimedia.scmp.com##.section:style(position: relative !important;)
multimedia.scmp.com##.stickyLinks:style(position: relative !important; bottom: 0 !important;)
multimedia.scmp.com##.w-clearfix.section-2:style(position: absolute !important;)

For the paywall floating bottom bar on articles I could add scmp.com##.tp-modal [id^="offer-"]:upward(2) but then users are blind to know why articles don't load after three free article views. This floating bottom banner could also be fixed with

  1. ||cdn.tinypass.com^$script,domain=scmp.com (less aggressive) or
  2. ||cdn.tinypass.com^$script (More aggressive)

but I'm hesitant to add this to Web Annoyances Ultralist since this is a paywall. These filters may be better in a personal filter list or a filterlist specifically meant to evade paywalls.