yourduskquibbles / webannoyances

Fix and remove annoying web elements such as sticky headers, floating boxes, floating videos, dickbars, social share bars and other distracting elements.
Creative Commons Attribution Share Alike 4.0 International
1.29k stars 48 forks source link

Text becomes invisible on GitHub in editor panes #486

Open kriegaex opened 1 year ago

kriegaex commented 1 year ago

URL(s) where the issue occurs

Any GitHub issue, e.g. https://github.com/eclipse/org.aspectj/issues/195.

Describe the issue

When Web Annoyances Ultralist is active and I click "edit" on a GitHub issue description longer than the height of the editor pane and then jump to the end of the text using Ctrl-End, the bottom part of the text becomes invisible and only reappears after e.g. selecting the whole text to the top Shift-Ctrl-Pos1. If the cursor was at the end of the text last time before editing, the same occurs when jumping to the beginning with Ctrl-Pos1. Then the workaround is Shift-Ctrl-End, i.e. the reverse of before.

The same can happen when clicking "Quote reply" and the quoted text again is longer than the editor pane.

Deactivating Web Annoyances Ultralist fixes the issue.

Screenshot(s)

After clicking "edit" and jumping to the end of the text with Ctrl-End:

image

After Shift-Ctrl-Pos1, selecting all text up to the top:

image

After Ctrl-End again (workaround):

image

Versions

Settings

Notes

I think that one or more of these rules which change the DOM of the page are responsible for what happens:

image

This problem started a few weeks ago. I cannot remember it for a long time, but definitely more than just a few days.

yourduskquibbles commented 1 year ago

@kriegaex Thanks for reporting.. unfortunately having difficulty reproducing but wondering if you add github.com#@#.previewable-comment-form textarea:not([id="issue_body"]):style(max-height: 315px !important;) to My Filters is there no longer an issue?

yourduskquibbles commented 1 year ago

If that doesn't solve the issue, does also adding github.com#@##issue_body, #new_comment_field:style(max-height: 557px !important;) (or only this exception filter) fix the issue? I think it's likely due to the max-height I am setting, I can try removing those from the list if this solves the issue for you.

kriegaex commented 1 year ago

Interestingly, the problem currently does not occur anymore, after it had bugged me for a long time. I just re-tested, and for now, it seems to be OK. Either something must have changed in the filter, or maybe something in GitHub's DOM is a bit different than before. Another possibility is, that disabling the filter list and re-enabling it has somehow changed the order in which filters are applied, and therefore now it looks fine.