search

yourealwaysbe / forkyz

Forkyz Crosswords
GNU General Public License v3.0
39 stars 5 forks source link

Fix keyboard not working on initial clue list load #46

Closed evanc577 closed 2 years ago

evanc577 commented 2 years ago

Fixes the keyboard not working after opening the clue list. Previously you needed to tap on a square on top before the keyboard would start working.

I'm not an Android or Java programmer and have no idea what I'm doing but this seems to work...

yourealwaysbe commented 2 years ago

Thanks for this!

Personally i prefer it not showing when i open the clues list: i solve very slowly, and use the clue list only when starting a puzzle so i can skim through and pick off the easy ones. But i can see how it's annoying for the quick solvers.

There's probably a nice way of handling both, though i'm not sure which is best at the moment. If it's part of the keyboard show/hide behaviour, then it's clear what "always show" and "never show" should do, but not the other two modes. I could add another on/off setting for showing when opening the clue list, but that conflicts a bit with the keyboard show/hide modes.

evanc577 commented 2 years ago

Oh, I forgot there was a setting for keyboard show/hide behavior. I think the bug I was trying to fix only happens when it's set to "hide keyboard manually". But I see that my change doesn't work as expected when that setting is changed to something else.

yourealwaysbe commented 2 years ago

Oh, i see -- with the "manually hide keyboard" option, the keyboard is shown when the main puzzle screen opens, but not when the clue list is open. Making it show on when the clue list opens too makes sense. I'll keep it not showing for "hide keyboard on clue change" as this matches the main puzzle screen behaviour for that keyboard setting.

So then "always show keyboard" and "manually hide keyboard" lean towards showing the keyboard, while "hide keyboard on clue change" and "never show keyboard" lean towards not showing it. I'll put that in version20.

yourealwaysbe commented 2 years ago

Implemented by setting up the keyboard manager to determine the keyboard show/hide state when it's created. Will be in version20, which i'm hoping to release by Monday. Let me know if it doesn't work for you.

Thanks for the bug report and pull request!