yourealwaysbe / forkyz

Forkyz Crosswords
GNU General Public License v3.0
38 stars 5 forks source link

[Feature request] Custom .puz sources #5

Closed mooomooo closed 3 years ago

mooomooo commented 4 years ago

Would it be possible to create a new CustomDownloader to allow arbitrary puzzle downloads, using settings options for e.g. a datestring-formatted URL (https://man7.org/linux/man-pages/man1/date.1.html) and update frequency?

P.S. This fork has been an amazing improvement, thank you for creating it! I've been using it since the rebrand over a year ago, and I just noticed that you're still developing it. Forgive me if I'm being selfish, but I've come up with a few feature requests that I'll note in the issues here -- I feel that these enhancements would make this app even better, if you think they'd be worth working on.

yourealwaysbe commented 4 years ago

I don't really get much time to implement things unless i'm really motivated, so i probably won't get around to this myself anytime soon. Pull requests welcome :)

From a backend perspective it's not difficult -- though could be cleaner. Essentially, the AbstractDownloader class would need a small implementing class that supplies the configured URLs.

The the UI needs implementing, which is always a faff on Android.

Relevant code parts are below. There's too much hard-coding of available downloaders going on, and this would be a good time to fix that.

yourealwaysbe commented 3 years ago

This is now supported in version13 (thanks for the pull request). (23b51da)

Future development of the feature would be great (not just .puz, more than one source, specify days available), but for now i'll close the issue and leave the rest to natural development.