search

yourealwaysbe / forkyz

Forkyz Crosswords
GNU General Public License v3.0
39 stars 5 forks source link

Dashes support and more french sources #67

Closed slock83 closed 1 year ago

slock83 commented 1 year ago

Hello,

Thanks for maintaining this app ! I recently noticed that the dashes were missing in french crosswords, so I added support for them (not the best implementation, but I didn't want to reimplement half the renderer just for that).

I also added a few more sources for french crossword (I could find much more, but I don't want to clutter the downloader too much)

I also fixed parsing the clues in some rare cases (clue refers only accross, but directly bellow box).

Thanks !

yourealwaysbe commented 1 year ago

Awesome, thanks for the work!

I'm slightly ahead of you (here and here) with the dashes, so there'll be something to do to make it compatible with the current version 39 branch. I have some time tonight and it looks like fairly light adjustments.

Thanks for the downloaders too. Looks good at a glance, though the share and source URLs need adjusting. I'll tweak that tonight as well.

yourealwaysbe commented 1 year ago

Btw, i noticed the dashes when implementing the Le Parisien reader, but couldn't figure out how they were represented in the data format. Thanks for solving that mystery :)

yourealwaysbe commented 1 year ago

Oh, should the dashes be dots? (Both are now supported.)

slock83 commented 1 year ago

Yes your implementation seems much cleaner (It's been a while since I've used java), I planed on adding dotted support too and on cleaning things up at that point, but hadn't seen the v39 branch, my bad ...

And I get why you didn't figure out the format when you implemented the reader initially : the implementation is bugged on the web player ... In french we usually use dashes to represent multi part clues (two words) or some acronyms, so I just used that and suddenly the coordinates made sense :)

As for the dots, I believe we mostly use dashes for this, so dashes are fine.

yourealwaysbe commented 1 year ago

but hadn't seen the v39 branch, my bad ...

I'm not sure you'd want to try to develop against that branch anyway. I keep rebasing and force-pushing when i change my mind about something, realise i've forgotten a file, merge WIP commits, &c.

And I get why you didn't figure out the format when you implemented the reader initially : the implementation is bugged on the web player

Aha!

yourealwaysbe commented 1 year ago

I've merged the changes in now (here and here). I tweaked the code a bit to fit the coding style.

These crosswords also answer a question i had about whether dotted/dashed bars should mark the end of words :)

Thanks!

yourealwaysbe commented 1 year ago

I've removed the Notre Temps Geant Force 2 puzzle source. It was originally down as being weekly on Saturdays. However, it's actually every 9-10 days, which makes it unpredictable (and broken for anything other than the base date).

I think it would be better as a PageScraper that would scrape the puzzle numbers from the puzzle page and download the most recent that hasn't been downloaded already.

You'd probably need a NotreTemps subclass of PageScraper, overriding the getPuzzleURLs so it can scrape for puzzle numbers and then return the urls to the data files. Plus maybe other tweaks to make it nice.

yourealwaysbe commented 1 year ago

The current working branch is version41. I'll probably release that soon.

yourealwaysbe commented 1 year ago

Version 41 is now in master. If i don't start a version42 in the next week, i won't start one until late April.