search

yourhead / s3

public info about s3
8 stars 7 forks source link

HTML templates with scope "page" are omitted #688

Closed yourhead closed 7 years ago

yourhead commented 7 years ago

In previous versions a compatibility shim was added to inject the template:

html::page

into

html::pageHeadBlow

this only occurs if there is no other pageHeadBelow template.

this shim was accidentally removed

joeworkman commented 7 years ago

Shouldn't this map to pageBodyAbove? I am pretty sure that page scoped templates were not inserted into <head> before.

yourhead commented 7 years ago

fixed in beta 3

yourhead commented 7 years ago

Shouldn't this map to pageBodyAbove? I am pretty sure that page scoped templates were not inserted into before.

Pretty sure that they did go in the head before. I triple checked. Both the code path and the behavior of prior versions.

But you can certainly move things to the body with those other scopes like pageBodyAbove and pageBodyBelow

joeworkman commented 7 years ago

OK. I double checked and I migrated the ones that I was thinking of to use the newer page scopes.