search

yourhead / s3

public info about s3
8 stars 7 forks source link

crash when using addType with link values #746

Closed yourhead closed 7 years ago

yourhead commented 7 years ago

when an addType + button is clicked Stacks crashes if one of the properties on the stack is a link

yourhead commented 7 years ago

@elixirgraphics reported

yourhead commented 7 years ago

the crash is when comparing the value to the clear value. the codepath for new addType stacks is still too differentiated. somehow the default value is not being assigned at the same time. this value of null is slipping through. when it gets compared -- there is a special case for links (to compare hrefs (RWLink doesn't implement isEqual -- ugh!!! -- why have i not overridden this yet!>!>)

any who -- i've fixed the obvious error -- should really fix the source of this (the addType node creation) and the other right way (RWLink isEqual override).

yourhead commented 7 years ago

fixed in 3.5.1