search

yourhead / s3

public info about s3
8 stars 7 forks source link

Server key over HTTPS #760

Closed barchard closed 6 years ago

barchard commented 6 years ago

May be a good idea to serve this file over HTTPS instead of HTTP?

https://github.com/yourhead/s3/blob/41052bbb696038dfa60686162b11267ac237d615/secure_stack_API/YHStacksUpdate.php#L22

yourhead commented 6 years ago

all the files are served from github, which of course supports https. do you mean something else?

barchard commented 6 years ago

yes, but this .pem file is not being served via HTTPS:

const STACKS_PUBLIC_KEY_URL = "http://yourhead.com/appcast/RW6/Stacks3/stack_public_key.pem";
joeworkman commented 6 years ago

This is what pull requests are for...

barchard commented 6 years ago

changing the URL doesn't mean he has a cert ready to make this work :)

yourhead commented 6 years ago

it's the right thing to do. but is low on the practicality scale. i'll put it on the someday list.