Exception Classes are not PHP5 compatible

yourivw / LEClient

An easy-to-use PHP ACME v2 client library, designed to be used with LetsEncrypt.

MIT License

204 stars 98 forks source link

Exception Classes are not PHP5 compatible #122

Open damanic opened 2 years ago

damanic commented 2 years ago

Class constant visibility is only allowed since PHP 7.1

Example in LEConnectorException

    public const NONEWNONCEEXCEPTION            = 0x11;
    public const ACCOUNTDEACTIVATEDEXCEPTION    = 0x12;
    public const METHODNOTSUPPORTEDEXCEPTION    = 0x13;
    public const CURLERROREXCEPTION             = 0x14;
    public const INVALIDRESPONSEEXCEPTION       = 0x15;

TheRealSimpleSimon commented 2 years ago

Considering that PHP8 is current, I doubt anyone will have time to maintain support for PHP5.

damanic commented 2 years ago

@TheRealSimpleSimon Considering the guidance on your repo states The minimum required PHP version is 5.2.0., the pull request is valid.

Did anyone actually need to introduce constant visibility? If you are keeping the change you need to update your minimum required PHP version to 7.1