search

yourivw / LEClient

An easy-to-use PHP ACME v2 client library, designed to be used with LetsEncrypt.
MIT License
204 stars 98 forks source link

Library will not finalize an order due to ACMEv2 change (which is in production) #39

Closed ghost closed 5 years ago

ghost commented 6 years ago

As of Thursday, July 5th a new order status has been put in production, this means that orders will get a ready status. It appears that orders which have this status fail to finish with the current version of this library.

https://community.letsencrypt.org/t/acmev2-order-ready-status/62866

ghost commented 6 years ago

It appears that the only fix needed is to change line 512 of LEOrder.php (at least this fixed the issue on my end while testing/debugging.

        if($this->status == 'pending')

to

        if($this->status == 'pending' || $this->status == 'ready')
yourivw commented 6 years ago

Should have been resolved by merging pull requests, now released in v1.1.3.