yourkarma / JWT

A JSON Web Token implementation in Objective-C.
MIT License
351 stars 107 forks source link

Fixing possible null dereference. #164

Closed valeriyvan closed 6 years ago

valeriyvan commented 6 years ago

According to coding standards in 'Creating and Returning NSError Objects' the parameter may be null

New Pull Request Checklist

This merge request fixes / refers to the following issues: ...

Pull Request Description

...

lolgear commented 6 years ago

@valeriyvan

Hi! thanks for so many PR requests! But could you reduce amount of them? Most of PRs are related to JWTDesktopSwift. It would be nice to have one PR that improves code quality. Another PRs are essential (null dereference) or aesthetic (fix spelling).

It would be nice to have groups of PRs.

valeriyvan commented 6 years ago

I have spent time making commits granular. One thing = one commit = separate PR. Granular PRs usually ease work making easy rejecting just one not liked thing among many changes.
Could you please accept these PRs as is? Next time I will make PRs more grouped.