search

yourlabs / django-autocomplete-light

A fresh approach to autocomplete implementations, specially for Django. Status: v4 alpha, v3 stable, v2 & v1 deprecated.
https://django-autocomplete-light.readthedocs.io
MIT License
1.8k stars 467 forks source link

Implementing a grouped queryset #1186

Closed epoiate closed 4 years ago

epoiate commented 4 years ago

Enables Select2 to group options by a related model #1151

jpic commented 4 years ago

That's fine for me, do you want to add a test to ensure that nobody breaks your code in the future or are you fine as-is ?

codecov[bot] commented 4 years ago

Codecov Report

Merging #1186 into master will decrease coverage by 0.38%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
- Coverage   89.96%   89.58%   -0.39%     
==========================================
  Files         113      113              
  Lines        2203     2218      +15     
==========================================
+ Hits         1982     1987       +5     
- Misses        221      231      +10
Impacted Files Coverage Δ
src/dal_select2/views.py 89.24% <33.33%> (-10.76%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56b1cfa...6cefd5e. Read the comment docs.

epoiate commented 4 years ago

If you think its fine, we can merge as it is

jpic commented 4 years ago

I think so, it should document it https://github.com/yourlabs/django-autocomplete-light/blob/master/docs/api.rst#views-1