search

yourlabs / django-autocomplete-light

A fresh approach to autocomplete implementations, specially for Django. Status: v4 alpha, v3 stable, v2 & v1 deprecated.
https://django-autocomplete-light.readthedocs.io
MIT License
1.81k stars 468 forks source link

Data token separators #1266

Closed fraimondo closed 3 years ago

fraimondo commented 3 years ago

Fix for #1113

I need that to allow for a single tag with commas.

jpic commented 3 years ago

Hi @fraimondo

Thank you for your contribution! Looking forward to release this ;)

Ok to add data-token-separators, but why require data-tags to allow data-token-separator?

If there's no reason for that then it would be less confusing if you could remove this limitation.

Also, please fetch origin/master and rebase, fixes for django 4 have been merged already so you would not need this commit anymore (normally :joy:)

Thank you, and keep up the great work !

:tophat:

fraimondo commented 3 years ago

I just modified the logic. The idea is to be backwards-compatible so if someone uses data-tags, then this will be the same as using data-token-separators with a value of [',']

jpic commented 3 years ago

Very good, thanks!

Will be in next release in the following weeks

fraimondo commented 3 years ago

Excellent! Thank you.

On 23. Nov 2021, at 14:36, jpic ∞ @.***> wrote:

Very good, thanks!

Will be in next release in the following weeks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/yourlabs/django-autocomplete-light/pull/1266#issuecomment-976907123, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABCJDA6V73MCM4RE3DPGF53UNPGJVANCNFSM5HSZQJIQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.