yourlabs / django-autocomplete-light

A fresh approach to autocomplete implementations, specially for Django. Status: v4 alpha, v3 stable, v2 & v1 deprecated.
https://django-autocomplete-light.readthedocs.io
MIT License
1.79k stars 467 forks source link

Django 4.0 imports with fallbacks #1279

Closed blag closed 2 years ago

blag commented 2 years ago

This PR fixes more imports for Django 4.0+ while still retaining the old import paths to maximize reverse compatibility.

whob13 commented 2 years ago

Is there a timeline for when this will be merged? I'd like to transition a project to 4.0 but will wait on this if it's coming soon.

Mogost commented 2 years ago

It's better to use version checking instead of feature checking. https://adamj.eu/tech/2020/01/07/feature-checking-versus-version-checking/

blag commented 2 years ago

It's better to use version checking instead of feature checking. https://adamj.eu/tech/2020/01/07/feature-checking-versus-version-checking/

I would be happy to merge a PR into my branch implementing that.

whob13 commented 2 years ago

I think @Mogost makes a valid point in his comment, but perhaps this can be merged to remain compatible with Django 4 to unblock it? Thank you for the response, @blag !

blag commented 2 years ago

Superseded by #1268. :tada: