search

yourlabs / django-autocomplete-light

A fresh approach to autocomplete implementations, specially for Django. Status: v4 alpha, v3 stable, v2 & v1 deprecated.
https://django-autocomplete-light.readthedocs.io
MIT License
1.79k stars 467 forks source link

Compatibility with dark mode. #1280

Closed ammarCanc closed 2 years ago

ammarCanc commented 2 years ago

In the dark mode the text color of the selected field is not visible. The dropdown list's text color is also not visible (images attached).

The issue is also mention in #1245 .

Screenshot 2022-01-17 at 3 35 18 PM Screenshot 2022-01-17 at 3 35 02 PM
waheedahmed commented 2 years ago

@jpic Could you please review this?

jpic commented 2 years ago

Code looks fine, does it still work for you in light mode after applying this patch?

ammarCanc commented 2 years ago

Yes it's working fine with light mode as well.

jpic commented 2 years ago

Thanks for your feedback y'all !!

Released in 3.9.1rc1

waheedahmed commented 2 years ago

Hello @jpic,

Thank you for reviewing the PR and release! just wanted to check when it will be available on PyPI?

waheedahmed commented 2 years ago

PyPi is still pointing to 3.8.2.

jpic commented 2 years ago

Yes, rc = Release candidate version, pip doesn't install them by default, you would need to install django-autocomplete-light>=3.9.1rc1

Released in 3.9.1

waheedahmed commented 2 years ago

@jpic thank you!