search

yourlabs / django-autocomplete-light

A fresh approach to autocomplete implementations, specially for Django. Status: v4 alpha, v3 stable, v2 & v1 deprecated.
https://django-autocomplete-light.readthedocs.io
MIT License
1.8k stars 467 forks source link

fix: Fix event format for Django 4.2 #1335

Closed last-partizan closed 1 year ago

last-partizan commented 1 year ago

Event format has been changed for Django 4.2, and old variant isn't working.

https://github.com/django/django/commit/eabc22f919e6c1774842e628400b87ac56c47bce

This PR fixes it, but we need to decide how to handle the old django versions.

Cleaner variant would be to support only latest django version, and those with old version should use old library versions.

If we want to support all django versions, i need to modify this, to check if $newFormset is defined or not, and then use two different call variants.

What do you think?

jpic commented 1 year ago

Should be fine, thank you!

jpic commented 1 year ago

Please try 3.10.0-rc3 and let me know if it works for you

last-partizan commented 1 year ago

Yes, it's fixed. No more errors when adding inline.