search

yourlabs / django-session-security

A little javascript and middleware work together to ensure that the user was active during the past X minutes in any tab he has open. Otherwise, display a warning leaving a couple of minutes to show any kind of activity like moving the mouse. Otherwise, logout the user.
http://django-session-security.rtfd.org
MIT License
309 stars 142 forks source link

Django 3.0 compatibility #130

Closed cw0102 closed 4 years ago

cw0102 commented 4 years ago

{% load static %} has been the drop in replacement for {% load static from staticfiles %} since Django 1.10 and it has been deprecated for several versions. Django 3.0 removes the staticfiles template tag.

Unfortunately the testing matrix seems broken since sbo_selenium is no longer maintained. I can verify I manually tested that it works on Django 1.10-3.0, but to fix the tests would likely require a near full rewrite.

jpic commented 4 years ago

Thanks !

Well, there's not so many browser tests iirc, perhaps the easier would be to contribute to sbo_selenium, or use splinter that i've been using in other projects (although nowadays i use cypress)

jsm222 commented 4 years ago

https://github.com/jsm222/django-session-security/tree/update-tests uses geckodriver directly for tests, so it does not need sbo_selenium.