search

yoursunny / NDNts

NDN libraries for the Modern Web
https://ndnts-docs.ndn.today
ISC License
31 stars 9 forks source link

keychain: remove export * as ... syntax #20

Closed pulsejet closed 12 months ago

pulsejet commented 1 year ago

This isn't ideal but @microsoft/api-extractor doesn't support this syntax for whatever reason. This blocks creation of user types in NDN Play so it either needs to be patched or not run in CI.

I understand if you don't want this change; feel free to close in that case.

yoursunny commented 1 year ago

Can you make an ESLint plugin to enforce this requirement? This ensures new violations do not get introduced.

pulsejet commented 1 year ago

Good thought. I've no experience with this but will give it a shot later.

yoursunny commented 1 year ago

I found the api-extractor issue here: https://github.com/microsoft/rushstack/issues/2780 I don't see a technical reason that this syntax cannot be supported by api-extractor. Thus, the recommended solution is implementing it in api-extractor.

This is valid TypeScript syntax. Thus, I will not remove it from the source code itself, and will not adopt ESLint rule that removes such.

If you are using the .d.ts from packages, I could accept a PR that modifies the generated code via mk/build-post.mjs.

yoursunny commented 12 months ago

Solved in https://github.com/yoursunny/NDNts/commit/41f4db68260baf4601b81fd52b34e5e3f8c6cbfa