yous / whiteglass

Minimal, responsive Jekyll theme for hackers
https://yous.github.io/whiteglass/
MIT License
725 stars 197 forks source link

Add some styling for tables #15

Closed leonardehrenfried closed 6 years ago

leonardehrenfried commented 6 years ago

Right now they look very unstyled.

leonardehrenfried commented 6 years ago

That's a good point. I used padding as I originally had some spacing on the left and right hand side as well and I didn't want margin to interfere with the 100% width.

Since I don't do that anymore, I will change it to margin.

Am 13.11.2017 3:57 vorm. schrieb "Chayoung You" notifications@github.com:

@yous commented on this pull request.

In _sass/whiteglass/_base.scss https://github.com/yous/whiteglass/pull/15#discussion_r150439753:

@@ -25,7 +25,11 @@ body { font-kerning: normal; }

- +table {

  • width: 100%;
  • padding: 0 0 20px 0;

How about specifying margin instead of padding for correct border?

border: 1px solid; with padding: 0 0 20px 0;: [image: screenshot 2017-11-13 11 55 02] https://user-images.githubusercontent.com/853977/32707785-a2956aba-c869-11e7-8fb4-30318d8a6fc8.png

border: 1px solid; with margin: 0 0 20px 0;: [image: screenshot 2017-11-13 11 55 25] https://user-images.githubusercontent.com/853977/32707794-ad51b634-c869-11e7-9c4d-d515b392fa53.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yous/whiteglass/pull/15#pullrequestreview-75988347, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJPMlPLiaTv083xFTGk76r_Ed_2wrYiks5s16_9gaJpZM4Qa865 .

yous commented 6 years ago

Thanks, @leonardehrenfried!