search

yous / whiteglass

Minimal, responsive Jekyll theme for hackers
https://yous.github.io/whiteglass/
MIT License
732 stars 201 forks source link

Appropriately size h1s in the post content #19

Closed michaelpj closed 6 years ago

michaelpj commented 6 years ago

Perhaps bad practice, but I often use h1s in my article body as the top-level headers. At least, it should look reasonable if you do (currently the h1s are smaller than the h2s).

I've followed the scheme and made them 6px bigger than the h2s. However, this makes them quite close in size to the .post-title h1. It might be nice to scale all the .post-content headers by a couple of px.

yous commented 6 years ago

Thanks for the pull request! I've just checked the size of h1 in article, and it seems good.

This is how it looks on screen width > 800px: screenshot 2018-01-10 14 22 37

And on screen width <= 800px: screenshot 2018-01-10 14 23 20

Because .post-title uses 42px on > 800px, and 36px on <= 800px, I think it's better when we use smaller font-size for .post-title h1.

How about 32px? Still looks similar with post title, but it looks like: screenshot 2018-01-10 14 28 54

michaelpj commented 6 years ago

(You meant "try a smaller .post-content h1" rather than .post-title, right? Or that's what it looks like from your screenshots)

Hm, I actually like your first version better - in the second one I think the h1 would be hard to distinguish from the h2 if there was some text in between.

I agree that this makes the .post-content h1 a bit big, but my inclination would be to keep them all distinct by downsizing all the .post-content headers a bit. Thoughts?

yous commented 6 years ago

Hmm, right. I prefer to keep the size of other headers, because I'm using h2 and smaller headers on posts. Distinguishing .post-content h1 from .post-content h2 would be more important than distinguishing .post-title from .post-content h1 because the position of .post-title is always fixed, and they are all the same h1 tag. Merging.

michaelpj commented 6 years ago

Thanks!

One other thing I was considering - perhaps the size of the h1 could be a variable, along with the multiplier by which subsequent headers shrank. That way it would be relatively easy to tweak this.