search

youseedk / dna

CSS framework for yousee.dk
ISC License
6 stars 6 forks source link

icons do not scale well with the smaller version on button #243

Closed Lubbe91 closed 3 years ago

Lubbe91 commented 4 years ago

The icon is a little big with the new smaller version of the button

Original: image

Small: image

And if no text is provided, the icon disappears.

No text original: image

No text small: image

havgry commented 4 years ago

This is a bug but it's not clear to me what the expected outcome is. The small modifier only reduces the font-size and horizontal padding - the icon disappears due to the latter. As such, it doesn't really make much sense to apply the small modifier to icon-only buttons.

Lubbe91 commented 4 years ago

My thought was that, when small is applied, it would offer a smaller version of both text and icons, to accommodate smaller screens.

But I've test it on my phone and it actually looks alright when it's icon-only. Image from iOS

But I would still argue that text & icon combination, needs to match a bit better in size.

grandorf commented 3 years ago

@Lubbe91 can you look at this? The issue is 6 months old. So I would argue that we need to fix the issue or decide not to prioritise it and close it.

Lubbe91 commented 3 years ago

I think we can close this one @grandorf