search

youseedk / dna

CSS framework for yousee.dk
ISC License
6 stars 6 forks source link

6 new icons for DNA #255

Closed OVA-robin closed 4 years ago

OVA-robin commented 4 years ago

6 new icons.zip

havgry commented 4 years ago

What's the process for adding icons? Do they need approval? I don't mind making the PR.

OVA-robin commented 4 years ago

The process is that I post them here so someone can add them to the DNA som my frontender can use them.

havgry commented 4 years ago
  1. The Error404 already exists, as far as I can see - it's just named unplayable. I suggest we keep the existing icon and name.
  2. The landline name is already taken by a different icon. Again, I'm not sure what the process is for adding icons.
OVA-robin commented 4 years ago

The "Error404" doesn't exists. The one called "unplayable" is a tv with an X. "Error404" is a laptop with an X.

ok, since "Landline" already exists I will rename the icon to DSL, but then I also have to rename cable to COAX so they follow the same naming.

OVA-robin commented 4 years ago

Skal jeg oploade ikonerne igen med de nye navne eller omdøber du dem bare selv? landline = dsl cabel = coax

havgry commented 4 years ago

@OVA-robin I'll finish up the pull request today. I don't need anything further from you :) Hopefully, we can get this out soon.