Accessibility role for Spinner component

youseedk / dna

CSS framework for yousee.dk

ISC License

6 stars 6 forks source link

Accessibility role for Spinner component #259

Closed MBehtemam closed 3 years ago

MBehtemam commented 4 years ago

it's a good idea to add and suggest accessibility roles for components. there are a lot of benefit for having role also it help me for writing tests in React because react-testing-library encourage us to select and find element on DOM by their roles, so I don't need to pass test-id.

grandorf commented 3 years ago

@MBehtemam can you help to fix this?

grandorf commented 3 years ago

@MBehtemam please add some sources or information about this. And maybe suggest a solution to this issue?